diff --git a/src/knot-holder-entity.cpp b/src/knot-holder-entity.cpp index 7abd16cbaf08add795aa6172595da7429c25dde4..75f36089c93c7eaed1acec286b101cf4b2e36728 100644 --- a/src/knot-holder-entity.cpp +++ b/src/knot-holder-entity.cpp @@ -172,21 +172,40 @@ static Geom::Point sp_pattern_knot_get(SPPattern const *pat, gdouble x, gdouble return Geom::Point(x, y) * pat->getTransform(); } +bool +PatternKnotHolderEntity::knot_missing() const +{ + SPPattern *pat = _pattern(); + return (pat == nullptr); +} + +SPPattern* +PatternKnotHolderEntity::_pattern() const +{ + return _fill ? SP_PATTERN(item->style->getFillPaintServer()) : SP_PATTERN(item->style->getStrokePaintServer()); +} + Geom::Point PatternKnotHolderEntityXY::knot_get() const { - SPPattern *pat = _fill ? SP_PATTERN(item->style->getFillPaintServer()) : SP_PATTERN(item->style->getStrokePaintServer()); + SPPattern *pat = _pattern(); return sp_pattern_knot_get(pat, 0, 0); } Geom::Point PatternKnotHolderEntityAngle::knot_get() const { - SPPattern *pat = _fill ? SP_PATTERN(item->style->getFillPaintServer()) : SP_PATTERN(item->style->getStrokePaintServer()); - + SPPattern *pat = _pattern(); return sp_pattern_knot_get(pat, pat->width(), 0); } +Geom::Point +PatternKnotHolderEntityScale::knot_get() const +{ + SPPattern *pat = _pattern(); + return sp_pattern_knot_get(pat, pat->width(), pat->height()); +} + void PatternKnotHolderEntityAngle::knot_set(Geom::Point const &p, Geom::Point const &/*origin*/, guint state) { @@ -214,7 +233,7 @@ PatternKnotHolderEntityAngle::knot_set(Geom::Point const &p, Geom::Point const & void PatternKnotHolderEntityScale::knot_set(Geom::Point const &p, Geom::Point const &origin, guint state) { - SPPattern *pat = _fill ? SP_PATTERN(item->style->getFillPaintServer()) : SP_PATTERN(item->style->getStrokePaintServer()); + SPPattern *pat = _pattern(); // FIXME: this snapping should be done together with knowing whether control was pressed. If GDK_CONTROL_MASK, then constrained snapping should be used. Geom::Point p_snapped = snap_knot_position(p, state); @@ -242,13 +261,6 @@ PatternKnotHolderEntityScale::knot_set(Geom::Point const &p, Geom::Point const & } -Geom::Point -PatternKnotHolderEntityScale::knot_get() const -{ - SPPattern *pat = _fill ? SP_PATTERN(item->style->getFillPaintServer()) : SP_PATTERN(item->style->getStrokePaintServer()); - return sp_pattern_knot_get(pat, pat->width(), pat->height()); -} - /* Filter manipulation */ void FilterKnotHolderEntity::knot_set(Geom::Point const &p, Geom::Point const &origin, unsigned int state) { diff --git a/src/knot-holder-entity.h b/src/knot-holder-entity.h index e6d2ba23174406133e97bef8867628d7046d068f..92c4d553663efac835cc5856ce975f6310dfb6ad 100644 --- a/src/knot-holder-entity.h +++ b/src/knot-holder-entity.h @@ -24,6 +24,7 @@ class SPItem; class SPKnot; class SPDesktop; +class SPPattern; class KnotHolder; namespace Inkscape { @@ -63,6 +64,7 @@ public: should be derived from KnotHolderEntity and override these functions */ virtual void knot_set(Geom::Point const &p, Geom::Point const &origin, unsigned int state) = 0; virtual void knot_ungrabbed(Geom::Point const &p, Geom::Point const &origin, unsigned int state) = 0; + virtual bool knot_missing() const { return false; } virtual Geom::Point knot_get() const = 0; virtual void knot_click(unsigned int /*state*/) {} @@ -105,35 +107,36 @@ protected: /* pattern manipulation */ -class PatternKnotHolderEntityXY : public KnotHolderEntity { +class PatternKnotHolderEntity : public KnotHolderEntity { public: - PatternKnotHolderEntityXY(bool fill) : KnotHolderEntity(), _fill(fill) {} - Geom::Point knot_get() const override; + PatternKnotHolderEntity(bool fill) : KnotHolderEntity(), _fill(fill) {} + bool knot_missing() const override; void knot_ungrabbed(Geom::Point const &p, Geom::Point const &origin, guint state) override {}; - void knot_set(Geom::Point const &p, Geom::Point const &origin, unsigned int state) override; -private: +protected: // true if the entity tracks fill, false for stroke bool _fill; + SPPattern *_pattern() const; }; -class PatternKnotHolderEntityAngle : public KnotHolderEntity { +class PatternKnotHolderEntityXY : public PatternKnotHolderEntity { public: - PatternKnotHolderEntityAngle(bool fill) : KnotHolderEntity(), _fill(fill) {} + PatternKnotHolderEntityXY(bool fill) : PatternKnotHolderEntity(fill) {} Geom::Point knot_get() const override; - void knot_ungrabbed(Geom::Point const &p, Geom::Point const &origin, guint state) override {}; void knot_set(Geom::Point const &p, Geom::Point const &origin, unsigned int state) override; -private: - bool _fill; }; -class PatternKnotHolderEntityScale : public KnotHolderEntity { +class PatternKnotHolderEntityAngle : public PatternKnotHolderEntity { public: - PatternKnotHolderEntityScale(bool fill) : KnotHolderEntity(), _fill(fill) {} + PatternKnotHolderEntityAngle(bool fill) : PatternKnotHolderEntity(fill) {} + Geom::Point knot_get() const override; + void knot_set(Geom::Point const &p, Geom::Point const &origin, unsigned int state) override; +}; + +class PatternKnotHolderEntityScale : public PatternKnotHolderEntity { +public: + PatternKnotHolderEntityScale(bool fill) : PatternKnotHolderEntity(fill) {} Geom::Point knot_get() const override; - void knot_ungrabbed(Geom::Point const &p, Geom::Point const &origin, guint state) override {}; void knot_set(Geom::Point const &p, Geom::Point const &origin, unsigned int state) override; -private: - bool _fill; }; /* Filter manipulation */ diff --git a/src/knotholder.cpp b/src/knotholder.cpp index 9594a233f6abefc29a2a6239cab22ad24806c41a..d12f61a98f9f35d378ba968ed7d152fd7da781f0 100644 --- a/src/knotholder.cpp +++ b/src/knotholder.cpp @@ -105,8 +105,15 @@ void KnotHolder::updateControlSizes() void KnotHolder::update_knots() { - for (auto e : entity) { - e->update_knot(); + for (auto e = entity.begin(); e != entity.end(); ) { + // check if pattern was removed without deleting the knot + if ((*e)->knot_missing()) { + delete (*e); + e = entity.erase(e); + } else { + (*e)->update_knot(); + ++e; + } } }