Skip to content

Some safe backports to 1.2.x (crashfixes, etc.)

Nathan Lee requested to merge nathanal/inkscape:20220517backports into 1.2.x

I definitely haven't backported everything necessary for the next release (notably, I'm missing the tool-switching fix which is larger but should be safe iirc, and the pdf save fixes and the dataloss fix), but just going through some in 1.2.x that are small (with some bias towards my own commits 😅)

Marking as draft till I've sorted the list but want to get the pipeline started earlier.

List of fixes

A couple extra fixes:

  1. Fix switching tools for Czech locale (LC_COLLATE=cs_CZ.UTF-8), and probably other locales too but only on Linux or OSes that set this (so not Windows). (#3571 (closed), !4477 (merged), d0e1ff62)
  2. Fix crash on LPE to path if original-d is M 0 0 and references are bad (this is a rare situation, but may well occur to "normal" user) (#3599 (closed), !4515 (merged), e0e0620a)

Rest:

  1. Re-enable the batch export button if cancelled (#3605 (closed), !4519 (merged), 6b9550fe)
  2. Fix crash checking and detecting wrong element type with debugging mode "Check attributes and style properties" (and extraneous white-space in non-text elements if xml:space="preserve" set) (#2799 (closed), !4513 (merged), 2fe9cf9a)
  3. Improve sub-menu appearance when no recent files are found (An entry "No items found" is shown instead of a weird blank bar) (#2926 (closed), !4488 (merged), a3c85c7f)
  4. Fonts used in the document are legible in dark mode (now bold instead of blue) (#910 (closed), !4474 (merged), 7fe10487)
  5. Fix crash double clicking on 3d box (#3538 (closed), !4468 (merged), f6e0b532)
  6. Fix Measurement tool's convert to item's text box (previously incorrect size/often not noticeable) (#3412 (closed), !4462 (merged), 266d37a1)
  7. Re-add swap fill-and-stroke shortcut, make remove filters do something in CLI mode (#3502 (closed), !4410 (merged), 0f8d9ddc)
  8. Fix sub-menus not showing if translated with accent in some Windows OS locales (e.g. Central European), (#3152 (closed), !4392 (merged), 0b545f95)

Suitability for backport:

Below is from a cursory re-review, not digging deep into each function (that's the logic with the above selection of fixes to backport).

Newer set:

  1. Very much desired, fixes a bad problem. Not the smallest fix but should be safe and already marked as backport. re-reviewed.
  2. Very suitable, small, isolated, only affects situation that was previously crashing. Not bothering to retest since it's not going to create new bugs.

Rest:

  1. Very suitable, small, isolated, "bug-free", confirm still fixed (appimage)
  2. Very suitable, small, isolated, "bug-free", confirm still fixed (appimage)
  3. Suitable, small, isolated. Any bugs should be minor, but unlikely to be buggy, confirm still fixed (appimage, windows)
  4. Suitable, small, isolated, "bug-free". Changes appearance so may get some eyebrows, but we're already committed to this, confirm still fixed (appimage)
  5. Very suitable, small, isolated, fix otherwise crashing state, confirm still fixed (appimage)
  6. Very suitable, small, isolated, confirm still fixed (appimage)
  7. Sorta suitable, moderately small, isolated. I've gone through it a few times, confirm still fixed (appimage)
    • Eep! needs fix in CLI mode, action does different thing to group if GUI is absent. Note: still would be a minor problem to getting this merged as previously the action was missing. Update; Nope appears to be a difference in what select-all does in GUI v in shell. If I use select-by-id to select a group, I get the same behavior.
  8. Very suitable, small, isolated, "bug-free". Not going to retest (it's a pain), but no reason it wouldn't work.
Edited by Nathan Lee

Merge request reports