Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • inkscape inkscape
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,527
    • Issues 1,527
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Inkscape
  • inkscapeinkscape
  • Merge requests
  • !3629

Refactor LayerManager

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Owens requested to merge doctormo/inkscape:layers-refactoring into master Nov 03, 2021
  • Overview 20
  • Commits 6
  • Pipelines 12
  • Changes 63

Many problems with the layers can't be fixed until the code that manages layers is cleaned up.

  • Part 1a removes passthrough functions and signals from the SPDesktop object and moves them to the Layer Model or Layer Manager as needed.
  • Part 1b consolidates the LayerManager, LayerModel and layer-fncs into one file and one unique_ptr object.
  • Part 1c move some functions from context-fcns and selection-chemistry and review LayerManager as an API. (not much moved)

Test plan (things that should be tested)

  • Changing layers (any method) results in widgets updating
  • Drawing creates objects in selected layer
  • CLI still works with the selection
  • Selecting an object changes the layer to that object's layer
  • Changing any aspect of the layer (name, locked, etc) updates the UI
  • Select all does the expected things regards to layers
  • Creating layer, moving layer and moving objects between layers works
Edited Nov 08, 2021 by Martin Owens
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: layers-refactoring