Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • inkscape inkscape
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,545
    • Issues 1,545
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 144
    • Merge requests 144
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • InkscapeInkscape
  • inkscapeinkscape
  • Merge requests
  • !3541

Fix crash scrolling across line height units (use after free)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nathan Lee requested to merge nathanal/inkscape:inbox3260 into master Sep 28, 2021
  • Overview 1
  • Commits 2
  • Pipelines 4
  • Changes 1

Fixes inbox#3260 (closed)

Use after free happens during scrolling, as the deleted spobjects are still kept inside by the Layout, which we iterate over later. Rebuilds the layout before we use it.

Also some very light refactoring. Just remove some nesting, grammar in docs and a bit of gratuitous modification.

Best to view commit by commit (fix in !3541 (b7cbccdf)). Crash should be less likely to occur with !3544 (merged)

Edited Oct 02, 2021 by Nathan Lee
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: inbox3260