Skip to content

Fix loss of id on undoing stroke to path

Nathan Lee requested to merge nathanal/inkscape:inkscape2759 into master

Fix #2759 (closed)

While the crash is definitely the same as #2714 (closed), it does reveal a bad bug, the ID being lost (in the ifdef in SPDocument) after undoing stroke-to-path.

Bisecting the change, it was introduced in 5507a9f4, from the introduction of out->setAttribute("id",id); in path-outline.cpp . I simply moved that after the item with that id was removed.

For the more generic crash in #2714 (closed), the superfluous obj_copy = newitem->getRepr(); introduced under COPYPASTECLONESTAMPLPEBUG in clipboard.cpp is the problem, I think. I'd like to confirm with Jabier before doing anything

Update: for #2759 (closed) I confirmed with Jabier, however he has told me that the id-less copy may not work in the future and removing id during an Inkscape session should be prevented.

Edited by Nathan Lee

Merge request reports