Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • inkscape inkscape
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,674
    • Issues 1,674
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 146
    • Merge requests 146
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • InkscapeInkscape
  • inkscapeinkscape
  • Merge requests
  • !2769

Feature: Text shape-padding and shape-subtract controls (and menu item)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Owens requested to merge doctormo/inkscape:feature-text-shape-padding-knot into master Feb 10, 2021
  • Overview 21
  • Commits 3
  • Pipelines 10
  • Changes 12

This merge request adds a simple knot feature which allows flow text in SVG 2.0 to set the shape-padding and shape-subtract attributes.

text-subtract

An improvement that could be made is using const Geom::Point chk = c.pointAt(c.nearestTime(req)); to find the point nearest to the curve of the shape instead of opting for the top right visualBounds location. But this is left for the next iteration.

Tested with multiple shapes, transformations, different text types.

There's a small cleanup in the text tool which pushes the test for what should have knots to the knot handler itself, since it was seemingly duplicating code (and I think the rectangle adjustment node wouldn't have appeared on tool switching based on the logic there) so that should now work slightly better as well.

flow-feature

Edited Jun 22, 2021 by Martin Owens
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature-text-shape-padding-knot