Remove an old debug message that used to spam stdout.

VaibhavMalik4187 authored Jul 03, 2022 and Nathan Lee committed Jul 03, 2022

Removed the blue color of user defined keyboard shortcuts from the
preferences. The blue color was illegible. Now the user defined keyboard
shortcuts are in bold.

Fixes: inkscape/inkscape#910

PBS authored May 11, 2022 and PBS committed Jul 03, 2022

These are a holdover from C that escaped porting.

PBS authored May 11, 2022 and PBS committed Jul 03, 2022

This was previously a handwritten slist. Changing to vector reduces
needless allocations and has better locality.

(As these containers are both small in size and large in number, we
opted not to use a unordered_map.)

PBS authored May 08, 2022 and PBS committed Jul 03, 2022

Get the path/pixbuf from the FontInstance once at construction time,
rather than on every call to update/render. Removes a multithreading
obstacle, as FontInstance cannot be safely accessed off-main-thread.

PBS authored Jun 25, 2022 and PBS committed Jul 03, 2022

Plus a lot of very minor refactoring of pattern-related classes in
preparation for later pattern work.

PBS authored May 04, 2022 and PBS committed Jul 03, 2022

Some local variables named "beststate" in DrawingItem are no longer used,
so we remove them.

PBS authored May 04, 2022 and PBS committed Jul 03, 2022

When a style is set on a DrawingItem, copy the variables we need
access to out of SPStyle and into DrawingItem member variables.
(The number of such variables is very small, so this has no cost.)
This reduces the reliance on SPStyle from future off-main-thread code.

Minor changes:

 * Make SPStyle refcount mutable.
 * Make various style-related methods/arguments const.
 * Some reformatting in the DrawingItem hierarchy.

PBS authored Apr 24, 2022 and PBS committed Jul 03, 2022

* Make NRStyle's patterns unique_ptr.
* Make NRStyle's dashes vector.
* Other minor reformatting.

PBS authored Apr 23, 2022 and PBS committed Jul 03, 2022

Plus make SPFilter::_build_renderer const, now that's possible.

PBS authored Jun 25, 2022 and PBS committed Jul 03, 2022

Change DrawingItem transforms from raw pointer to unique_ptr.

Martin Owens authored Jun 30, 2022 and Martin Owens committed Jul 03, 2022

This outputs postscript and eps formats and moves some of the key
code out of the pdf exporter to make it more generic.

The printing postscript is refactored to allow multiple pages with
both vector and raster output options.

Use align dialog alignment target. Follow-up to e30a5ffc,
b23fb719, and 6ed748a0.

* Ensure that the rasterization of filter effects on PDF export gets
  triggered for clones, whenever the <use> chain contains a filtered
  item. Make sure this happens also for filtered items inside groups,
  any clones of directly filtered groups, and any nested combinations
  of these.
* Do not directly render items inside a marker's definition, even if
  the marker is defined outside of <defs>, but do render such markers
  on paths that reference them.
* Ensure that "context-fill" and "context-stroke" styles are respected
  even when applied to a path contained in arbitrarily nested groups
  inside a marker definition.

Fixes #3214
Fixes #3498
Fixes #3566
Fixes #3635

These tests check the correctness of PDF export of items with filters
and their clones when these items appear on page 2 of a multipage PDF
file. Thus, they serve as regression tests for the referenced issues.

Reference: #3214
Reference: #3635

aadilshabier authored Jun 16, 2022 and aadilshabier committed Jun 30, 2022

Members changed:
  - _router
  - _event_log

aadilshabier authored Jun 14, 2022 and aadilshabier committed Jun 30, 2022

The function was previously returning a new vector while also taking a
reference to a vector as an argument. This makes a static function
get_avoided_items_rec() to handle the recursive search.

aadilshabier authored Jun 07, 2022 and aadilshabier committed Jun 30, 2022

This change makes Inkscape::Selection a non GC object, we also replace
the raw pointers in SPDesktop and SPDocument with std::unique_ptr's to
make memory management easier.

aadilshabier authored Jun 07, 2022 and aadilshabier committed Jun 30, 2022

This makes the selection object accessible only with an accessor method.
This is preparation to removing the GC from Selection.

- Made DocumentSubset::_relations a smart ptr
- Made SPDocument::_profileManager a smart ptr
- Made SPDocument::getProfileManager() return a reference

PBS authored Jun 28, 2022 and PBS committed Jun 29, 2022

* Make visible hairlines not fade out as the canvas is rotated.
* Correctly enable the use of the cairo function if available.

Fixes #3652

Rafał Siejakowski authored Jun 22, 2022 and Rafał Siejakowski committed Jun 28, 2022

PDF and PostScript documents created by Cairo specify page dimensions
as integers (in PostScript points), so the pages in export output end
up slightly larger than what Inkscape requests. This change gives the
user the option to either keep the relative size of the drawing (with
respect to the page) or to keep the absolute sizes. The new option is
selected from the PDF export dialog.

Fixes #3569

Rafał Siejakowski authored Jun 19, 2022 and Rafał Siejakowski committed Jun 26, 2022

Fix a segfault occurring when a "maskhelper" group is ungrouped by the
user manually. This is achieved by preventing the temporary removal of
masks from destroying the group prematurely which would then crash the
actual delete code in sp_item_group_ungroup().

Fixes #3616

Use the official numpy wheel and don't build it ourselves. This avoids
an issue with a broken accelerator on macOS.
Fixes #3551

Update jhb to v0.15.

Refactoring of /trace:

* Bring code in line with C++/project guidelines.
* Remove unnecessary/near-unnecessary code and classes.
* Split out cielab.cpp.

Design changes:

* Foreground detection now creates its own temporary display
  tree rather than re-using that of the active desktop,
  eliminating a slight multithreading obstacle.
* Foreground detection now rasterises the display tree rather
  than hit-testing every pixel, improving efficiency and
  allowing handling of alpha.

Bugs fixed:

* Instant crash when tracing image due to recent pixbuf
  immutability changes in 797be5a7. (See #3634 below.)
* Flawed caching optimisations in siox and trace.
* Various bugs with foreground detection.

Fixes #3634.

This fixes the sort predicate used by the paint servers dialog to
not return true if a == b, which on some implementations can crash
std::sort.

Ensure SPShape::_curve is immutable to allow thread-safe sharing in the future. It essentially already was -this commit just enforces that in code while cleaning up a few immutability violators, mainly in the connector tool and SPPath::set_transform.

aadilshabier authored Jun 04, 2022 and aadilshabier committed Jun 23, 2022

Fixes #3516

When the drawing items are mutated during a modification
event cycle, there is the possibility that the drawing item
hierarchy is not consistent and will crash.

Also fixes lack of updates on selectionModified.

Fixes #3638
Fixes #3582

In this revision, Inkscape cannot create margins while resizing the
document to content. Once Martin's new margin functionality is ready,
the relevant tests can be re-enabled.

Maintainers: Feel free to revert this commit when that happens.

When the y-axis points up, the reference point for shifting the drawing
items and scrolling the canvas view should be the max() rather than the
min() of the y-interval of the desired bounding box.  Clean up the code
and remove the remnants of margins functionality (soon to be replaced).

Fixes #3609

Co-authored-by: Martin Owens <doctormo@gmail.com>

Make sure objects are aligned to visual top/bottom regardless of whether
the y-axis points up or down. Additionally, prevent unnecessary copies.

Fixes #3613

Rafał Siejakowski authored Jun 15, 2022 and Rafał Siejakowski committed Jun 18, 2022

Ensure that page units are correctly converted to pixels when exporting
a rasterized filter effect to PDF, fixing a regression from reference.

Reference: 0b2fe598
Fixes: #3628

David Gene authored Mar 30, 2021 and Nathan Lee committed Jun 18, 2022

When offset is too large, edges were cut off.

See !2974

Rafał Siejakowski authored May 31, 2022 and Rafał Siejakowski committed Jun 17, 2022

Handle double mouse clicks on the tool buttons directly instead of
relying on a time-based hack.

Fixes #2537