Lock all guide button clarification (UI)

Steps to reproduce:

  • Open Inkscape
  • Create some guides
  • Press the lock button in the left left corner (intersection of the two rulers)
    • Note the guides are all locked
  • Create new guides
    • Note new guides are not locked by default
  • Save the file and close the file (keep window open).
    • Note in document properties > guides, locking is not enabled
    • Note the lock button is still enabled.
  • Close inkscape
  • Open inkscape
  • Open the file we just saved
    • Note in document properties > guides, locking is enabled
    • Note the lock button is not enabled, and the new guide is still not locked.
  • (Updated, extra steps below)
  • Close inkscape
  • Open inkscape, loading the file on open
    • Note all guides are locked now.

What should have happened?

  1. The lock button near the rulers should always reflect what the Document properties shows.
  2. Perhaps the lock states should have a clearer difference, e.g. it should look unlocked when not enabled. Ehh, my suggestion might not work well at such a small size.
  3. If we expect new guides to be unlocked when lock is enabled, the checkbox/toggle button is an inappropriate UI choice. Otherwise, new guides should be locked if lock all guides is enabled.

Note issues 1 and 2 might be made redundant by issue 3.

Inkscape Version and Operating System:

1.0alpha2 (ebfcda5a1b, 2019-08-03) Linux Mint 19.1

Edited by Nathan Lee