Toolbar: Second Click on active tool unchecks/un'selects' tool's button

Summary:

Clicking on an active tool removes 'active' appearance of the button. This happens when double clicking to open tool preferences and also during misclicks on active tool (tangential issue: changing from simple to advanced snap popover exhibits similar behavior and probably a related much minor issue)

Steps to reproduce:

  • open Inkscape
  • select a tool
  • select it again
  • alternatively, access tool preferences via toolbar

What happened?

  • tool's button lost active status

What should have happened?

  • tool's button should reflect active status

Sample attachments:

rRbFrcsnJU

Version info

Inkscape 1.2-dev (2b1b0490, 2021-10-21)

    GLib version:     2.70.0
    GTK version:      3.24.30
    glibmm version:   2.66.1
    gtkmm version:    3.24.5
    libxml2 version:  2.9.12
    libxslt version:  1.1.34
    Cairo version:    1.17.4
    Pango version:    1.48.10
    HarfBuzz version: 2.9.1

    OS version:       Windows 10 1903