Take from selection copies a few unnecessary properties

Steps to reproduce:

  • reset preferences
  • open Inkscape
  • create a text element
  • change fill color (e.g. to red)
  • keep text selected
  • double click text tool icon (opens up text tool preferences)
  • click Take from selection (button at the bottom)
  • create another piece of text

What happened?

  • Comparing the old and new text's styles, the new default has too many properties.
Old:
fill:black;fill-opacity:1;line-height:1.25;stroke:none;font-family:sans-serif;font-style:normal;font-weight:normal;font-size:40px;

New:
font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:39.9999px;line-height:1.25;font-family:sans-serif;font-variant-ligatures:normal;font-variant-position:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-feature-settings:normal;font-variation-settings:normal;text-indent:0;text-align:start;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000000;letter-spacing:normal;word-spacing:normal;text-transform:none;writing-mode:lr-tb;direction:ltr;text-orientation:mixed;dominant-baseline:auto;baseline-shift:baseline;text-anchor:start;white-space:normal;shape-padding:0;shape-margin:0;inline-size:0;opacity:1;vector-effect:none;fill:#ff0000;fill-opacity:1;stroke:none;stroke-width:0.999999;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;-inkscape-stroke:none;stop-color:#000000;stop-opacity:1

What should have happened?

  • stop-color and stop-opacity aren't necessary (happens with all tools)
  • for all other tools, font-variation-settings isn't necessary
  • It still seems like too many properties are copied, but if I guess this is expected if we want the user to have consistent results

Version Info:

  • Inkscape 1.2-dev (1fe83e36da, 2021-05-15) Linux Mint 20
  • Inkscape 1.0alpha (9dee831, 2019-01-15) appimage Linux Mint 20
  • Not replicated Inkscape 0.92.5 (0ad1ac969f, 2020-08-06) Linux Mint 20