Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • extensions extensions
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • InkscapeInkscape
  • extensionsextensions
  • Merge requests
  • !444

Fix #454

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Neuhauser requested to merge joneuhauser/extensions:zero-length-dasharray into master Feb 25, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 7

What does the merge request do?

Fix issue #454 (closed) by decreasing the tolerance to convert superpaths to closeto commands.

It seems to work in my tests, but long term I'd like to get rid of superpaths for this reason. It just doesn't have all the information needed to work reliably (notably, whether a subpath is closed or not).

Implementation notes

The problem is that M 10, 10 l 0 0 does render a dot at 10, 10, but M 10, 10 l 0 0 z does not, and neither does M 10, 10 z (might be related to inkscape#1154 or inkscape#1131? not sure)

Since we only draw a tiny line segment, some lineto commands are converted to Z if the tolerance is set too high (numerical inaccuracies).

Summary for release notes

(no mention needed, bug was only introduced in 1.2-alpha)

Checklist

  • Add unit tests (if applicable)
  • Changes to inkex/ are well documented
  • Clean merge request history
Edited Feb 25, 2022 by Jonathan Neuhauser
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: zero-length-dasharray