Skip to content
Snippets Groups Projects
Vadim Golub's avatar
commented on merge request !56 "docs: change Gitlab token scope to Developer" at Infracost / Infracost GitLab-CI template

Yeah, it might be tricky. We will probably revisit this in the future when older versions become unsupported. Thank you very much for bringing our ...

Eligio Alejandro Mariño Garcés's avatar
closed merge request !56 "docs: change Gitlab token scope to Developer" at Infracost / Infracost GitLab-CI template
Eligio Alejandro Mariño Garcés's avatar
commented on merge request !56 "docs: change Gitlab token scope to Developer" at Infracost / Infracost GitLab-CI template

Thank you for your response and considering it. I understand. It makes sense. I'll close the MR then....

Vadim Golub's avatar
commented on merge request !56 "docs: change Gitlab token scope to Developer" at Infracost / Infracost GitLab-CI template

Sorry for the late reply. We think we should keep the Maintainer for now, as we need to support older versions of self-managed GitLab, thus they wo...

Eligio Alejandro Mariño Garcés's avatar
commented on merge request !56 "docs: change Gitlab token scope to Developer" at Infracost / Infracost GitLab-CI template

Hi @vadimgolub . Were you able to try this? It's working OK for me so far.

Eligio Alejandro Mariño Garcés's avatar
commented on merge request !56 "docs: change Gitlab token scope to Developer" at Infracost / Infracost GitLab-CI template

Thank you for reviewing! I thought that. It might be that Gitlab is updating the permissions and roles matrix for writing MR comments.

Vadim Golub's avatar
commented on merge request !56 "docs: change Gitlab token scope to Developer" at Infracost / Infracost GitLab-CI template

Hi @gmeligio! Thank you for opening the merge request! This is interesting, we made this change c2b465ea because of the Group access token limitati...

Eligio Alejandro Mariño Garcés's avatar
opened merge request !56 "docs: change Gitlab token scope to Developer" at Infracost / Infracost GitLab-CI template
Ali Khajeh-Hosseini's avatar
Ali Khajeh-Hosseini's avatar
deleted branch add_test_step at Infracost / Infracost GitLab-CI template
Tim McFadden's avatar
Tim McFadden's avatar
accepted merge request !55 "docs: add test step" at Infracost / Infracost GitLab-CI template
Tim McFadden's avatar
approved merge request !55 "docs: add test step" at Infracost / Infracost GitLab-CI template
Ali Khajeh-Hosseini's avatar
opened merge request !55 "docs: add test step" at Infracost / Infracost GitLab-CI template
Ali Khajeh-Hosseini's avatar
pushed new branch add_test_step at Infracost / Infracost GitLab-CI template
Ali Khajeh-Hosseini's avatar
Ali Khajeh-Hosseini's avatar
  • c2b465ea · fix: maintainer access always works
Ali Khajeh-Hosseini's avatar
Ali Khajeh-Hosseini's avatar