Skip to content

Incorrect Invocation DONE calcul for MetaWF

Description

Observed

When running an Analysis with a WF with subWFs, sometimes it:

  • Goes to READY TO REPORT with 0 data in the report
  • Goes to DOWNLOADING but fails there
  • Goes back and forth between DOWNLOADING and SCHEDULED

After analysis the root causes (checking Galaxy invocations/{invocation_id} payloads), we noticed that while the Invocation is DONE in ABRomics, and the main Invocation of the WF's state is "ready" in Galaxy, sometimes the subWFs are NOT DONE ("steps": [] instead of having the steps of the subWF).

Expected

The Invocation state in ABRomics should only be DONE when the main Invocation of the WF is "ready" and every subWFs' invocation are also "ready" (and don't have an empty "steps" attribute).

Tasks

  • Change Django to Galaxy' percentage_done / complet_jobs_summary to take in account aforementioned expected behavior

Related Issue

Issue 569 in abromics-analysis

EDIT - 2025-06-20

Description

New QC WF (Genomic 300625 and 160725 for FASTA) doesn't calculate the job percentage properly. Additional jobs can happen during the invocation run, thus the percentage should be based on the amount of WorkflowInvocationSteps "scheduled" by the amount of WorkflowInvocationSteps of the Workflow with an additional condition on the state of the last step:

  • If it's a job, then check the state of the job
  • If it's a subWF, then check the state of the last job
Edited by Amanda D.