fix(meta): regex matching attribute allowed values matches entire string

Regexes is now implicitly wrapped by `^` and `$` anchors, e.g. `/\d+/` matches
`1` but not `foo1` as it previously did.

While this is semi-breaking the intention was always to match the entire string
and was documented as such. Internally this is the only way it was used.

docs/guide/metadata/__tests__/__snapshots__/restrict-attributes.md.spec.ts.snap

@@ -114,7 +114,7 @@ Array [
         "column": 22,
         "context": Object {
           "allowed": Array [
-            /\\\\d\\+/,
+            /\\^\\\\d\\+\\$/,
           ],
           "attribute": "ducks",
           "element": "my-component",

docs/rules/__tests__/__snapshots__/attribute-allowed-values.md.spec.ts.snap

@@ -12,7 +12,7 @@ Array [
         "column": 4,
         "context": Object {
           "allowed": Array [
-            /\\.\\*/,
+            /\\^\\.\\*\\$/,
           ],
           "attribute": "href",
           "element": "a",

elements/html5.json

@@ -6,7 +6,7 @@
       "contenteditable": ["", "true", "false"],
       "dir": ["ltr", "rtl", "auto"],
       "draggable": ["true", "false"],
-      "id": ["/^\\S+$/"],
+      "id": ["/\\S+/"],
       "hidden": [],
       "tabindex": ["/-?\\d+/"]
     },

src/meta/table.spec.ts

@@ -436,7 +436,7 @@ describe("MetaTable", () => {
 			const meta = table.getMetaFor("foo");
 			expect(meta).not.toBeUndefined();
 			expect(meta?.attributes).toEqual({
-				attr: [/foo/],
+				attr: [/^foo$/],
 			});
 		});
 
@@ -453,7 +453,24 @@ describe("MetaTable", () => {
 			const meta = table.getMetaFor("foo");
 			expect(meta).not.toBeUndefined();
 			expect(meta?.attributes).toEqual({
-				attr: [/foo/i],
+				attr: [/^foo$/i],
+			});
+		});
+
+		it("should handle explicit anchors", () => {
+			expect.assertions(2);
+			const table = new MetaTable();
+			table.loadFromObject({
+				foo: mockEntry({
+					attributes: {
+						attr: ["/^foo/", "/bar$/", "/^baz$/"],
+					},
+				}),
+			});
+			const meta = table.getMetaFor("foo");
+			expect(meta).not.toBeUndefined();
+			expect(meta?.attributes).toEqual({
+				attr: [/^foo$/, /^bar$/, /^baz$/],
 			});
 		});
 

src/meta/table.ts

@@ -270,11 +270,11 @@ function expandRegexValue(value: string | RegExp): string | RegExp {
 	if (value instanceof RegExp) {
 		return value;
 	}
-	const match = value.match(/^\/(.*)\/([i]*)$/);
+	const match = value.match(/^\/\^?([^/$]*)\$?\/([i]*)$/);
 	if (match) {
 		const [, expr, flags] = match;
 		// eslint-disable-next-line security/detect-non-literal-regexp
-		return new RegExp(expr, flags);
+		return new RegExp(`^${expr}$`, flags);
 	} else {
 		return value;
 	}

src/parser/__snapshots__/parser.spec.ts.snap

@@ -22,7 +22,7 @@ Object {
       /\\^\\\\S\\+\\$/,
     ],
     "tabindex": Array [
-      /-\\?\\\\d\\+/,
+      /\\^-\\?\\\\d\\+\\$/,
     ],
   },
   "deprecatedAttributes": Array [
@@ -60,7 +60,7 @@ Object {
       /\\^\\\\S\\+\\$/,
     ],
     "tabindex": Array [
-      /-\\?\\\\d\\+/,
+      /\\^-\\?\\\\d\\+\\$/,
     ],
   },
   "deprecatedAttributes": Array [

test-files/elements/col-invalid.html

@@ -9,3 +9,17 @@
 		<col></col>
 	</colgroup>
 </table>
+
+<table>
+	<colgroup>
+		<!-- should not allow negative span -->
+		<col span="-1">
+
+		<!-- should not allow omitted/empty -->
+		<col span>
+		<col span="">
+
+		<!-- should not allow text -->
+		<col span="foobar4u">
+	</colgroup>
+</table>

test-files/elements/col-valid.html

@@ -4,3 +4,10 @@
 		<col>
 	</colgroup>
 </table>
+
+<!-- should allow integer span -->
+<table>
+	<colgroup>
+		<col span="2">
+	</colgroup>
+</table>

test-files/elements/colgroup-invalid.html

@@ -21,3 +21,20 @@
 	<thead></thead>
 	<colgroup></colgroup>
 </table>
+
+<table>
+	<!-- should not allow negative span -->
+	<colgroup span="-1"></colgroup>
+
+	<!-- should not allow omitted/empty -->
+	<colgroup span></colgroup>
+	<colgroup span=""></colgroup>
+
+	<!-- should not allow text -->
+	<colgroup span="foobar4u"></colgroup>
+
+	<!-- should not allow nested col when using span, but no rule currently covers this -->
+	<colgroup span="2">
+		<col>
+	</colgroup>
+</table>

test-files/elements/colgroup-valid.html

@@ -23,3 +23,8 @@
 	<colgroup></colgroup>
 	<thead></thead>
 </table>
+
+<!-- should allow integer span -->
+<table>
+	<colgroup span="2"></colgroup>
+</table>

test-files/elements/global-attributes-invalid.html

@@ -11,6 +11,10 @@
 <p id="foo bar"></p>
 
 <p hidden="foobar"></p>
+
+<!-- tabindex cannot be empty or textual (even with a number inside) -->
 <p tabindex=""></p>
 <p tabindex="foobar"></p>
+<p tabindex="foobar4u"></p>
+
 <p contextmenu="foobar"></p>

test-files/elements/select-invalid.html

@@ -3,3 +3,13 @@
 	<span>foo</span>
 	<div>bar</div>
 </select>
+
+<!-- should not allow negative size -->
+<select size="-1"></select>
+
+<!-- should not allow omitted/empty size -->
+<select size></select>
+<select size=""></select>
+
+<!-- should not allow text size -->
+<select size="foobar4u"></select>

test-files/elements/select-valid.html

@@ -11,3 +11,6 @@
 	<script></script>
 	<template></template>
 </select>
+
+<!-- should allow integer size -->
+<select size="10"></select>

test-files/elements/td-invalid.html

@@ -2,3 +2,19 @@
 <div>
 	<td>foo</td>
 </div>
+
+<table>
+	<tbody>
+		<tr>
+			<!-- should not allow negative colspan/rowspan -->
+			<td colspan="-1" rowspan="-1"></td>
+
+			<!-- should not allow omitted/empty colspan/rowspan -->
+			<td colspan rowspan></td>
+			<td colspan="" rowspan=""></td>
+
+			<!-- should not allow text colspan/rowspan -->
+			<td colspan="foobar4u" rowspan="foobar4u"></td>
+		</tr>
+	</tbody>
+</table>

test-files/elements/td-valid.html

@@ -17,3 +17,12 @@
 		</tr>
 	</tbody>
 </table>
+
+<!-- should allow integer colspan/rowspan -->
+<table>
+	<tbody>
+		<tr>
+			<td colspan="2" rowspan="2"></td>
+		</tr>
+	</tbody>
+</table>

test-files/elements/textarea-invalid.html

@@ -3,3 +3,13 @@
 	<span>foo</span>
 	<div>bar</div>
 </textarea>
+
+<!-- should not allow negative values -->
+<textarea cols="-1" maxlength="-1" minlength="-1" rows="-1"></textarea>
+
+<!-- should not allow omitted/empty values -->
+<textarea cols maxlength minlength rows></textarea>
+<textarea cols="" maxlength="" minlength="" rows=""></textarea>
+
+<!-- should not allow text values -->
+<textarea cols="foobar4u" maxlength="foobar4u" minlength="foobar4u" rows="foobar4u"></textarea>

test-files/elements/textarea-valid.html

 <textarea></textarea>
+
+<!-- should allow positive integers -->
+<textarea cols="1" maxlength="1" minlength="1" rows="1"></textarea>

test-files/elements/th-invalid.html

@@ -28,3 +28,19 @@
 		</tr>
 	</tbody>
 </table>
+
+<table>
+	<tbody>
+		<tr>
+			<!-- should not allow negative colspan/rowspan -->
+			<th scope="col" colspan="-1" rowspan="-1"></th>
+
+			<!-- should not allow omitted/empty colspan/rowspan -->
+			<th scope="col" colspan rowspan></th>
+			<th scope="col" colspan="" rowspan=""></th>
+
+			<!-- should not allow text colspan/rowspan -->
+			<th scope="col" colspan="foobar4u" rowspan="foobar4u"></th>
+		</tr>
+	</tbody>
+</table>

test-files/elements/th-valid.html

@@ -30,3 +30,12 @@
 		</tr>
 	</tbody>
 </table>
+
+<!-- should allow integer colspan/rowspan -->
+<table>
+	<tbody>
+		<tr>
+			<th scope="col" colspan="2" rowspan="2"></th>
+		</tr>
+	</tbody>
+</table>