`hestia.landCover` > update model logic so it complies with linear discounting
# 🌳 Feature Request
## Background
<!-- Describe the problem to solve, use cases, and intended users. -->
Under the new LSRG guidelines - which we need to comply with - linear discounting will become mandatory. As such, we need to modify the logic of the `hestia.landCover` model following the calculation methodology that follows:
"For the calculation of dLUC emissions through linear amortisation, the exact same steps are taken as described in section 2.1, with the important difference that the calculation is made 20 times over a 1-year period (although still with a three-year average)."
## Initial proposal
<!-- What is the proposal - please be specific. Use sub headings, bullet points, and/or tick boxes to break the proposal up. -->
We want to change the logic of the `hestia.landCover` model as follows:
- instead of returning a value for `permanentPasture`, `annualCropland`, `permanentCropland`, `forest` and `otherLand` 20 years prior to each Cycle associated to a Site, the model should run once and output a value for `permanentPasture`, `annualCropland`, `permanentCropland`, `forest` and `otherLand` for each year during a 20-year period preceding the first Cycle associated to a Site (still using a three-year average).
- under this new logic, we should now have `landCover` data for every single year over the 20 years preceding the first Cycle; therefore, there will no longer be any data gaps to gap-fill between our earliest Cycle / original `landCover` data and the data outputted by this model.
- under this new logic, the model will also only need to run for the first Cycle associated to a Site, and no longer for subsequent Cycles.
Current logic that we want to preserve:
- the model shouldn't output `landCover` nodes for years that already have `landCover` data (without Properties from the `blankNodesGroup` `Cover crops`).
- the model shouldn't output `permanentCropland` if the current land use is a permanent cropland; instead, it should output the specific permanent crop's term. For example, if the Cycle's Product is `Grapes, fruit`, the model should output `Grapes vine` instead of `Permanent cropland`.
- the model shouldn't run at all if there are already at least 20 years of historical land cover data in the Management node.
## Links / references
<!-- Add links and references. -->
[LUC_impact_dataset_-_Methodology_description__March_2024__-_For_website.pdf](/uploads/3a4f2e895ede512bc34299f0529253e9/LUC_impact_dataset_-_Methodology_description__March_2024__-_For_website.pdf)
## ⚠️ Implementation Considerations
- [x] **User experience:** The effects on user experience have been thought through, and steps have been taken to deliver the best outcome for team members and users.
- [ ] **Documentation:** The Guide has been updated, along with any other necessary documentation (or no updates are required).
- [ ] **Communication:** The correct steps have been taken to notify users and internal teams about this change (or no notification is required).
issue