Commit 06c71b0b authored by Kamil Trzciński's avatar Kamil Trzciński

Merge branch 'check-unhandeled-err' into 'master'

Rename test to be more descriptive

See merge request gitlab-org/gitlab-runner!1249
parents c0925f32 dcd94047
......@@ -34,7 +34,7 @@ func TestServiceWaiterCommand_NoEnvironmentVariables(t *testing.T) {
func TestServiceWaiterCommand_Execute(t *testing.T) {
func TestHealthCheckCommand_Execute(t *testing.T) {
cases := []struct {
name string
expectedConnect bool
......@@ -59,6 +59,7 @@ func TestServiceWaiterCommand_Execute(t *testing.T) {
require.NoError(t, err)
err = os.Setenv("SERVICE_TCP_PORT", strconv.Itoa(listener.Addr().(*net.TCPAddr).Port))
require.NoError(t, err)
// If we don't expect to connect we close the listener.
if !c.expectedConnect {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment