3.1.5 warnings
Hi @All , @agbuckley ,
this is not crucial, but there are some warnings with gcc-11.2.1 @ Fedora.
pluginATLAS/ATLAS_2014_I1307243.cc:30:26: warning: loop variable 'cat' of type 'const string&' {aka 'const std::__cxx11::basic_string<char>&'} binds to a temporary constructed from type 'const char* const' [-Wrange-loop-construct]
30 | for (const string& cat : { "inclusive", "gap" }) {
| ^~~
pluginATLAS/ATLAS_2014_I1307243.cc:30:26: note: use non-reference type 'const string' {aka 'const std::__cxx11::basic_string<char>'} to make the copy explicit or 'const char* const&' to prevent copying
pluginATLAS/ATLAS_2014_I1307243.cc: In member function 'virtual void Rivet::ATLAS_2014_I1307243::finalize()':
pluginATLAS/ATLAS_2014_I1307243.cc:155:26: warning: loop variable 'cat' of type 'const string&' {aka 'const std::__cxx11::basic_string<char>&'} binds to a temporary constructed from type 'const char* const' [-Wrange-loop-construct]
155 | for (const string& cat : { "inclusive", "gap" }) {
| ^~~
pluginATLAS/ATLAS_2014_I1307243.cc:155:26: note: use non-reference type 'const string' {aka 'const std::__cxx11::basic_string<char>'} to make the copy explicit or 'const char* const&' to prevent copying
make[2]: Leaving directory '/builddir/build/BUILD/Rivet-3.1.5/analyses'
pluginATLAS/ATLAS_2018_I1711114.cc: In member function 'virtual void Rivet::ATLAS_2018_I1711114::analyze(const Rivet::Event&)':
pluginATLAS/ATLAS_2018_I1711114.cc:43:23: warning: loop variable 'jet' of type 'const Rivet::Jet&' binds to a temporary constructed from type 'const fastjet::PseudoJet' [-Wrange-loop-construct]
43 | for (const Jet& jet : myJets) myTrimmedJets += Jet(trimmer(jet));
| ^~~
pluginATLAS/ATLAS_2018_I1711114.cc:43:23: note: use non-reference type 'const Rivet::Jet' to make the copy explicit or 'const fastjet::PseudoJet&' to prevent copying
Best regards, Andrii
P.S. Again -- really sorry for not creating a MR.