Skip to content

Useless log when successfully published a message

Created from orchestrator#284 (closed)

When executing Cucumber tests which are all fully successful, we get (log generated using --show-notifications):

[                   ] [INFO] Successfully published Notification with test plan id=ab44fb0d-b69c-405c-90db-f675b581984f : OK, null
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Test report parsing result received for step id=d42628fd-c3a7-4621-8df0-48e60b1d79a7
[                   ] [INFO] Running Allure command line on Linux environment for test plan id=ab44fb0d-b69c-405c-90db-f675b581984f
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Test report parsing result received for step id=7859a8d6-3d17-40f1-a613-f621c9bb37c4
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Successfully published Notification with test plan id=e4c0cbaa887db42701888c0931c30022 : OK, null
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Running Allure command line on Linux environment for test plan id=e4c0cbaa887db42701888c0931c30022
[                   ] [INFO] Test plan Allure report received for suite id=ab44fb0d-b69c-405c-90db-f675b581984f
[                   ] [INFO] Unknown test plan.
[                   ] [INFO] Successfully published AllureCollectorOutput with test plan id=ab44fb0d-b69c-405c-90db-f675b581984f : OK, null
[                   ] [INFO] Successfully published Notification with test plan id=ab44fb0d-b69c-405c-90db-f675b581984f : OK, null
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Test plan Allure report received for suite id=e4c0cbaa887db42701888c0931c30022
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Successfully published AllureCollectorOutput with test plan id=e4c0cbaa887db42701888c0931c30022 : OK, null
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Successfully published Notification with test plan id=e4c0cbaa887db42701888c0931c30022 : OK, null
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Allure report for automated suite id=e4c0cbaa887db42701888c0931c30022 published to Squash TM

For the lines

[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Successfully published Notification with test plan id=e4c0cbaa887db42701888c0931c30022 : OK, null
[                   ] [INFO] Successfully published AllureCollectorOutput with test plan id=ab44fb0d-b69c-405c-90db-f675b581984f : OK, null
[                   ] [INFO] Successfully published Notification with test plan id=ab44fb0d-b69c-405c-90db-f675b581984f : OK, null
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Successfully published AllureCollectorOutput with test plan id=e4c0cbaa887db42701888c0931c30022 : OK, null
[                   ] [job 37b6e3cb-ab1c-490d-bfb9-06eb1887e70d] [INFO] Successfully published Notification with test plan id=e4c0cbaa887db42701888c0931c30022 : OK, null

what is the meaning of OK, null?

The code seems to be https://gitlab.com/henixdevelopment/open-source/opentestfactory/java-plugins/-/blob/main/otf-plugins-springboot-parent/OTF-allure-report-collector/src/main/java/org/opentestfactory/plugins/report/collector/allure/application/CollectorPublicationService.java.

There is no information in logging the successful publication of a message, we should remove this log (and keep only the log when the publication fails).