## Context Each artifact format (OCI, Maven, npm) ships its own datastore queries. Query review today happens per MR. That bar is too low: it does not surface issues that only appear across the full statement set of an endpoint. ## Goal Before each format's closed-beta launch, hold a holistic database review with the Database team. Organize by API endpoint. Cover every statement the endpoint executes. ## Scope Three per-format reviews, sequential, in this order: 1. OCI. Pathfinder format, furthest along. 1. Maven. 1. npm. Sequential, not parallel: lessons from OCI inform Maven, and so on. ## What each review covers - Every statement executed by every endpoint in the format's scope, read and write. - Transaction boundaries and locking. - Multi-statement patterns: insert-then-update, N+1 candidates, batching opportunities. - Cross-query index review: does the index set match the *combined* access pattern, not just individual statements? - Schema observations surfaced by the query patterns (denormalization, redundant joins, missing FKs). - PgBouncer compatibility: prepared statements and statement cache mode under transaction pooling on GitLab.com. ## What each review produces - A document with identified issues (severity-rated), improvement opportunities, and any schema-change recommendations. - Tracking issues for each actionable item. - A go/no-go from the Database team for the format's launch. ## Out of scope - Migration review. Already covered by the existing migration-review workflow. - Production-scale validation via Database Lab. Called out as future work; depends on AR being onboarded. ## References - Parent: [Artifact Registry Closed Beta](https://gitlab.com/groups/gitlab-org/-/work_items/21052) - Specs: [OCI](https://gitlab.com/gitlab-org/ops/artifact-registry/-/blob/main/docs/specs/S12-container-oci-local.md), [Maven](https://gitlab.com/gitlab-org/ops/artifact-registry/-/blob/main/docs/specs/S10-maven-local.md), [npm](https://gitlab.com/gitlab-org/ops/artifact-registry/-/blob/main/docs/specs/S11-npm-local.md)