### About gitlab~21094707 are responsible for the performance and security of code marked `category: integrations`. The quality of our codebase affects the group with regards to: - Error budgets. - Feature change locks. gitlab~12240031 codebase is reasonably unique in that other groups can consider themselves owners of certain integrations. To align with our responsibility to the category, we need more oversight into the quality of integrations code contributed. As a single data point of the problem: when I authored the Confluence integration https://gitlab.com/gitlab-org/gitlab/-/merge_requests/36262 as part of Create:Knowledge, I was unaware of an integrations group (ecosystem, then), or that another team might have interest in new integrations code. The MR received the required number of approvals by members of Knowledge and Stability. The MR was very simple, but Knowledge had extensive plans to expand it https://gitlab.com/groups/gitlab-org/-/epics/3629. ### Proposal Merge requests that touch integrations code should receive at least one approval from an integrations team member, like how a product intelligence review [is recommended](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61743#note_575277346) by GitLab Bot through `Danger` (see https://gitlab.com/gitlab-org/gitlab-dangerfiles/-/merge_requests/25 and https://gitlab.com/gitlab-org/gitlab/-/merge_requests/56098. This would be recommended but not enforced (similar to product intelligence). ### What might we review? We can use git history to get a sense of changes authored outside of the integrations team to our integrations model code if we look at the (old) `app/models/project_services` directory. There’s a recent flurry of documentation-related changes, but this was an anomaly while there was a documentation drive. We go back to [around March 2021](https://gitlab.com/gitlab-org/gitlab/-/commits/ff32d3705f06325238bafa6226ebc1b796c78b85/app/models/project_services) to get a better look. Notes: - Some of these may have been reviewed by integrations team members. - These don't represent "dangerous" changes, but just the frequency and kind of contributions. - This is just one directory. Changes ~6 months-worth: - March 2021: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57434 - Feb 2021: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/53534 - Jan 2021: gitlab@94c62315ed0621ff359ace9450dbed1f7a616291 - Jan 2021: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/51908 - Jan 2021: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50794 - Dec 2020: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/50030 - Nov 2020: gitlab@22504bd31d1bcc89fe422ee25e11459486a2a0aa - Nov 2020: gitlab@bfb73335eb4bb329c25cf8ca8350753ac6a96ee6 - Oct 2020: gitlab@7e70ed4c97d507e3116dd939dbc4ddcc00d6d28f There were a few changes during that period that would probably constitute noise gitlab@611071d95f15433bf4c27c990268e3812bca677c gitlab@92db697a3fb0c998d432878d807be63a1c930219 gitlab@0da7697fe014d25f5f3ff4d0cbaa5222ceb991ab gitlab@c938349ffcec45d7cf73ee079cb9077091cd40d2.