Identify and update split button dropdowns that change the default on click - Based on user testing
For better understanding, here are the differences between a "bad" example of a split button and a "good" example of a split button. | Bad (Deprecated) | Good | | ------ | ------ | | ![bad-example](/uploads/7fb6ee0860abe160956967533b7be05d/bad-example.mov) | ![good-example](/uploads/2d510b30a6ca620b71cfb7b030ef9a02/good-example.mov) | Based on user testing from https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/issues/681, the "changing default" button is not the expected behavior. We have deprecated this "changing default" button behavior for split buttons [in Pajamas](https://design.gitlab.com/components/button#split-dropdown). They also do not follow our standard split buttons, which take action immediately when clicking an option in the dropdown. Each instance below should be updated to the expected behavior (taking action immediately on click), or be redesigned to use a different method. | Instance | Screenshot | DRI | Issue/Epic to update | | ------ | ------ | ------ | ------ | | Create merge request dropdown - Issue | ![Screen_Shot_2021-06-09_at_10.43.31_AM](/uploads/dc6f3eee1375b7d20919d7f0eef2e7f0/Screen_Shot_2021-06-09_at_10.43.31_AM.png) | Holly | https://gitlab.com/gitlab-org/gitlab/-/issues/333146 | | Issues dashboard. Uses `shared/new_project_item_select` | ![Screen_Shot_2021-06-09_at_10.44.02_AM](/uploads/24648a010dfdb4552538668e73d87580/Screen_Shot_2021-06-09_at_10.44.02_AM.png) | Holly | https://gitlab.com/gitlab-org/gitlab/-/issues/333147 | | Merge requests Dashboard. Uses `shared/new_project_item_select` | ![Screen_Shot_2021-06-09_at_10.44.32_AM](/uploads/28c074241f4c6e2f1f21a3a2538aed00/Screen_Shot_2021-06-09_at_10.44.32_AM.png) | Mike Nichols | https://gitlab.com/gitlab-org/gitlab/-/issues/333147 | | Milestones Dashboard. Uses `shared/new_project_item_select` | ![Screen_Shot_2021-06-09_at_10.45.25_AM](/uploads/6a12ffc3a6994b54468b635dc69887e6/Screen_Shot_2021-06-09_at_10.45.25_AM.png) | Holly | https://gitlab.com/gitlab-org/gitlab/-/issues/333147 | | Group/Merge requests - Empty state. Uses `shared/new_project_item_select` | ![Screen_Shot_2021-06-09_at_10.45.59_AM](/uploads/7ba502f30d5dc04762c03055eefc7721/Screen_Shot_2021-06-09_at_10.45.59_AM.png) | TBD | https://gitlab.com/gitlab-org/gitlab/-/issues/333147 | | Comment/Start a thread | ![Screen_Shot_2021-06-09_at_10.46.29_AM](/uploads/1c8e2cfe3b63c1debb428a460af3d8c1/Screen_Shot_2021-06-09_at_10.46.29_AM.png) | Holly/Pedro | https://gitlab.com/groups/gitlab-org/-/epics/4943 | | Web IDE/GitPod - Project page | ![Screen_Shot_2021-06-09_at_10.47.08_AM](/uploads/cd503ac13080b9db645806c29b39c029/Screen_Shot_2021-06-09_at_10.47.08_AM.png) | Michael Le | https://gitlab.com/gitlab-org/gitlab/-/issues/333148 | **Note:** Most of the examples above use a shared file `= render 'shared/new_project_item_select`, in which you select a project from the dropdown, then take action. This file can be adjusted at the source.
epic