<!-- triage-serverless v3 PLEASE DO NOT REMOVE THIS SECTION --> *This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.* <!-- triage-serverless v3 PLEASE DO NOT REMOVE THIS SECTION --> In https://gitlab.com/gitlab-org/gitlab-design/issues/441 we highlighted many problems with the current approvals setup experience. This epic lists small improvements that can be made to clarify approvals and avoid hiccups. | Step | Screenshot | Emotions | Recommendations | |---|---|---|---| | 17. Below, I see a section dedicated to “Approvers” and a line saying “All members with Developer role or higher and code owners (if any)”. |  | 😵 I'm even more confused. What is the difference between Assignees and Approvers? Are approvers the people that will review my work? Are all members supposed to approve my work? I didn't add this, so this must be a default, but per project or for all of GitLab? | ⚡️ [Rename “Approvers” field and modal title to “Approval rules”.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65629) ⚡️ Left align “Add approvers” button. (to be addressed in https://gitlab.com/gitlab-org/gitlab-ce/issues/65524) ⚡️ Clearer label for default approval rule. (to be addressed after https://gitlab.com/gitlab-org/ux-research/issues/270) | | 18. I see another hint saying `Tip: add a CODEOWNERS to automatically add approvers based on file paths and file types. ` |  | 🤯 Where am I supposed to add this? And am I actually the person who should do so? The documentation gives the impression that somebody who administrates the project should do it. | ⚡️ [Show code owner approval rules in MR form.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65630) | | 22. I see the `Name` field. |  | 🤔 What do I have to fill in here? I can try the name of the person I want to add as approver, but nothing shows up, so this is probably wrong. The hint says QA or Security, so maybe I have to add groups here? I will just leave it empty for now. | [⚡️ Rename “Name” field to “Rule name”. ⚡️ Move field help text to field placeholder.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65631) | | 23. I see `No. approvals required`. |  | 🤔 This is interesting, it goes higher than the number of approvers. Does this mean that person has to approve 5 times? | | | 24. I search for a member. |  | 🤯 I know that this is the persons username, why doesn't he show up? Oh, it looks like I have to omit the `@`. But I do it like this everywhere else in the UI, this does not make sense! | ⚡️ [Auto-focus “Members” field in the approvers modal.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65633) ⚡️ [Rename approval rule “Members” to “Approvers”.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65629) ⚡️ [Support searching users/groups with `@` prefix.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65634) | | 26. I submit the form. The “Members” field shows two errors: “Please select and add a member” and ”Please select a name”. |  | 😡 I'm frustrated, I selected a member, why would I also have to click on `Add`? And what name am I supposed to use? | ⚡️ [Remove “Add” button and auto-add approval rule members when selecting from search results.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65635) ⚡️ [Make the approval rule “Name” field optional. If I select only 1 group/person, use that as the name.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65637) | | 30. I look at the people that I set as approvers. |  | 🤔 When I submit this form, will the approvers receive a notification? I'm afraid to spam all of these people. | ⚡️ [Show no. of group members in approver rule form.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65638) ⚡️ [Clarify if approvers receive a notification.](https://gitlab.com/gitlab-org/gitlab-ce/issues/65639) |