Skip to content

WIP: Added options --method, --body-data, --body-file

Archit Pandey requested to merge archit-p/wget2:add-option-method into master

This merge request closes #437 (closed)

Design

  • The variables method, body_data and body_file were added as strings to struct config.
  • config.method is checked before checking job->head_first, config.post_data or config.post_file to decide the method for requests.
  • Design for --body-data and --body-file was borrowed from that for --post-data and --post-file.

Possible Flaws

  • There is currently no check in the code to ensure only one of --post-data, --post-file, --body-data or --body-file are used.
  • There is no test in the test-suite for --post-data, --post-file, --body-data, --body-file and --method.

Approver's checklist:

  • The author has submitted the FSF Copyright Assignment and is listed in AUTHORS
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent with existing code
  • This feature/change has adequate documentation added (if appropriate)
  • No obvious mistakes / misspelling in the code
Edited by Archit Pandey

Merge request reports