Skip to content

Missing sig behavior

Neil Locketz requested to merge c0d3d/wget2:missing-sig-behavior into master

Approver's checklist:

  • The author has submitted the FSF Copyright Assignment and is listed in AUTHORS
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent with existing code
  • This feature/change has adequate documentation added (if appropriate)
  • No obvious mistakes / misspelling in the code

Addresses #338 (closed)

The MinGW build failed with the following output, and I'm not sure what to do about it:

it looks like wine32 is missing, you should install it.
multiarch needs to be enabled first.  as root, please
execute "dpkg --add-architecture i386 && apt-get update &&
apt-get install wine32"
Error in GnuTLS initialization: Failed to acquire random data.
Failed [0]: wget_hash_fast(moin,1) failed with -402
Failed [1]: wget_hash_fast(moin,2) failed with -402
Failed [2]: wget_hash_fast(moin,5) failed with -402
Failed [3]: wget_hash_fast(moin,7) failed with -402
Failed to hash (-402)
Failed to hash (-402)
Failed to hash (-402)
ERROR: 4 out of 195785 basic tests failed
This may completely break Wget functionality !!!
FAIL test.exe (exit status: 1)

Other than that, this adds fail/no-fail/disable option to verify-sig which changes the behavior in the case that a signature file is missing. The signature extension behavior has been changed also. Instead of issuing requests for the extensions in parallel, a queue of them are kept, and upon failure of one the next is tried.

Merge request reports