Memory leaks in tests/test-metalink.c
Investigate and fix to silence the leak sanitizer. Reproducible with
./configure --enable-fsanitize-asan --enable-fsanitize-ubsan
make clean
make check
Relevant output from tests/test-metalink.log:
Testing '../../src/wget2_noinstall -d --max-threads=1 --prefer-family=ipv4 -d --tries=1 'http://localhost:33197/archiveH2.gz' 2>&1'
...
=================================================================
==12592==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 457 byte(s) in 1 object(s) allocated from:
#0 0x7f6c4b281090 in realloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc2090)
#1 0x7f6c4ae79147 in wget_realloc /usr/oms/src/wget2/libwget/xalloc.c:130
#2 0x7f6c4ae64eac in wget_vasprintf /usr/oms/src/wget2/libwget/printf.c:63
#3 0x7f6c4ae6532a in wget_aprintf /usr/oms/src/wget2/libwget/printf.c:123
#4 0x562d0e07ed99 in main /usr/oms/src/wget2/tests/test-metalink.c:182
#5 0x7f6c484eb2b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
Direct leak of 446 byte(s) in 1 object(s) allocated from:
#0 0x7f6c4b281090 in realloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc2090)
#1 0x7f6c4ae79147 in wget_realloc /usr/oms/src/wget2/libwget/xalloc.c:130
#2 0x7f6c4ae64eac in wget_vasprintf /usr/oms/src/wget2/libwget/printf.c:63
#3 0x7f6c4ae6532a in wget_aprintf /usr/oms/src/wget2/libwget/printf.c:123
#4 0x562d0e07ec3b in main /usr/oms/src/wget2/tests/test-metalink.c:162
#5 0x7f6c484eb2b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
Direct leak of 440 byte(s) in 1 object(s) allocated from:
#0 0x7f6c4b281090 in realloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc2090)
#1 0x7f6c4ae79147 in wget_realloc /usr/oms/src/wget2/libwget/xalloc.c:130
#2 0x7f6c4ae64eac in wget_vasprintf /usr/oms/src/wget2/libwget/printf.c:63
#3 0x7f6c4ae6532a in wget_aprintf /usr/oms/src/wget2/libwget/printf.c:123
#4 0x562d0e07ea43 in main /usr/oms/src/wget2/tests/test-metalink.c:128
#5 0x7f6c484eb2b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
Direct leak of 317 byte(s) in 1 object(s) allocated from:
#0 0x7f6c4b281090 in realloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc2090)
#1 0x7f6c4ae79147 in wget_realloc /usr/oms/src/wget2/libwget/xalloc.c:130
#2 0x7f6c4ae64eac in wget_vasprintf /usr/oms/src/wget2/libwget/printf.c:63
#3 0x7f6c4ae6532a in wget_aprintf /usr/oms/src/wget2/libwget/printf.c:123
#4 0x562d0e07eae1 in main /usr/oms/src/wget2/tests/test-metalink.c:147
#5 0x7f6c484eb2b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
SUMMARY: AddressSanitizer: 1660 byte(s) leaked in 4 allocation(s).