Commit 660b3131 authored by Tim Rühsen's avatar Tim Rühsen 🛠
Browse files

* configure.ac: Add -Wno-declaration-after-statement to clang-15 manywarnings

parent 586ecf7c
......@@ -206,6 +206,10 @@ if test -n "$WARN_CFLAGS"; then
WARN_CFLAGS="$WARN_CFLAGS -Wno-reserved-identifier"
fi
if test $CLANG_VERSION -ge 15; then
  • Shouldn't this be 14?

    Also, maybe we shouldn't use -Weverything for clang? As per some clang devs that option is for testing clang itself (to test all possible warnings). There are even some conflicting warnings in -Weverything. And so just -Wall -Wextra should suffice instead?

    https://quuxplusone.github.io/blog/2018/12/06/dont-use-weverything/

  • Or we could continue this pattern of adding -Wno-* whenever upstream adds some noisy warning in -Weverything. I read some other opinions preferring this approach too...

  • You are right, I only tested with clang 15.

    Or we could continue this pattern of adding -Wno-* whenever upstream adds some noisy warning in -Weverything

    Let's do it until it really gets a hassle. So far it wasn't that much work.

  • Fix for clang-14 pushed.

Please register or sign in to reply
WARN_CFLAGS="$WARN_CFLAGS -Wno-declaration-after-statement"
fi
# remove all flags from WARN_FLAGS that are already in CFLAGS
# wget_WORD_REMOVE([WARN_CFLAGS], [$WARN_CFLAGS], [$CFLAGS])
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment