Skip to content

Re-introduce topendir on Windows with Unicode support

Hugo Beauzée-Luyssen requested to merge chouquette/gnutls:use_topendir_fixed into master

This is reintroducing the changes from !835 (merged) (merged) (and thus reverting those introducing in !860 (merged) (merged))

The failure was due to an incorrect byte order in the path provided to _topendir. I'm not sure if the 3rd patch is correct, there might be a macro/constant that can be use to express that the _gnutls_utf8_to_ucs2 caller wants native by order. Patch 2 & 3 might be better of squashed, but for the sake of reviewing, I think they're better of split for now.

This is a basically a copy of !931 (closed) because of some git issues.

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports