Skip to content
Snippets Groups Projects

win32: Use CertOpenStore instead of CertOpenSystemStore

Merged Hugo Beauzée-Luyssen requested to merge (removed):use_CertOpenStore into master
All threads resolved!

Add a description of the new feature/bug fix. Reference any relevant bugs.

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Nikos Mavrogiannopoulos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nikos Mavrogiannopoulos marked the checklist item There is a test suite reasonably covering new functionality or modifications as completed

    marked the checklist item There is a test suite reasonably covering new functionality or modifications as completed

  • Nikos Mavrogiannopoulos marked the checklist item Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md as completed

    marked the checklist item Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md as completed

  • Nikos Mavrogiannopoulos marked the checklist item This feature/change has adequate documentation added as completed

    marked the checklist item This feature/change has adequate documentation added as completed

  • Nikos Mavrogiannopoulos marked the checklist item No obvious mistakes in the code as completed

    marked the checklist item No obvious mistakes in the code as completed

  • Other than the copyright comment it looks good to me.

  • Nikos Mavrogiannopoulos approved this merge request

    approved this merge request

  • added 1 commit

    • ac34af71 - win32: Check that CertOpenStore is behaving as CertOpenSystemStore

    Compare with previous version

  • Updated the copyright, I'm not sure if this should be licensed to the FSF instead, if you'd prefer the copyright to change to something more specific please let me know!

  • The copyright is fine, thank you!

  • Nikos Mavrogiannopoulos resolved all discussions

    resolved all discussions

  • Nikos Mavrogiannopoulos enabled an automatic merge when the pipeline for ac34af71 succeeds

    enabled an automatic merge when the pipeline for ac34af71 succeeds

  • mentioned in commit 5d03564c

  • Thanks for merging this! (And the others :) )

  • mentioned in merge request !857 (merged)

  • Please register or sign in to reply
    Loading