Skip to content
Snippets Groups Projects

x509: add support for Russian extensions defined for qualified certificate

Merged Dmitry Baryshkov requested to merge GostCrypt/gnutls:gost-attrs into master
All threads resolved!

Add a description of the new feature/bug fix. Reference any relevant bugs.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Nikos Mavrogiannopoulos

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nikos Mavrogiannopoulos
  • Apart from one comment that LGTM. Just for confirmation that brings support to read these values, not write them.

  • added 1 commit

    • dbd92887 - x509: add support for Russian extensions defined for qualified certificate

    Compare with previous version

  • Yes, this is fine from my point of view. If one needs to write those values, he will do that on his own. Especially since those values should come from 'certified software instance' and we definitely are not :-)

  • Another option would be to write data values related to certified PKCS#11 tokens. But I've just started testing them anyway.

  • Nikos Mavrogiannopoulos resolved all threads

    resolved all threads

  • Nikos Mavrogiannopoulos approved this merge request

    approved this merge request

  • Nikos Mavrogiannopoulos marked the checklist item No obvious mistakes in the code as completed

    marked the checklist item No obvious mistakes in the code as completed

  • Nikos Mavrogiannopoulos marked the checklist item There is a test suite reasonably covering new functionality or modifications as completed

    marked the checklist item There is a test suite reasonably covering new functionality or modifications as completed

  • mentioned in commit 320137bf

  • Please register or sign in to reply
    Loading