Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • GnuTLS GnuTLS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gnutls
  • GnuTLSGnuTLS
  • Merge requests
  • !1515

crypto-api: support SIV ciphers with encryptv2 functions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daiki Ueno requested to merge dueno/gnutls:wip/dueno/siv-iov into master Jan 16, 2022
  • Overview 7
  • Commits 5
  • Pipelines 7
  • Changes 11

The AES-SIV ciphers have a peculiarity that it prepends authentication tag to the generated ciphertext rather than appending. The gnutls_aead_cipher_encryptv2 previously was not able to cope with that and returned wrong authentication tag. This patch adds a new cipher flag GNUTLS_CIPHER_FLAG_TAG_PREFIXED to indicate it.

This also adds a new API gnutls_aead_cipher_set_key to reset key of the context, per request in #1217 (closed).

Fixes: #1312 (closed), #1217 (closed)

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited May 10, 2022 by Zoltán Fridrich
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: wip/dueno/siv-iov