Skip to content

Avoid tests killing entire process groups

Alexander Sosedkin requested to merge asosedkin/gnutls:terminate-fixes into master

terminate() executed from the child process results in a kill(0, SIGTERM), bringing the whole pgroup down. exit(1) should be called instead.

In some cases it's not straightforward whether terminate is called from the parent or the child. Thus the second commit, adding a safeguard to terminate itself.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Daiki Ueno

Merge request reports