Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • GnuTLS GnuTLS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 252
    • Issues 252
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gnutlsgnutls
  • GnuTLSGnuTLS
  • Merge requests
  • !1199

RFC: ephemeral-api: add a mechanism to define ephemeral API

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Daiki Ueno requested to merge tmp-ephemeral-api into master Feb 28, 2020
  • Overview 5
  • Commits 2
  • Pipelines 5
  • Changes 11

Background: we are currently implementing ESNI and QUIC support API in GnuTLS. The problem is that those protocols are not finalized yet and we cannot know if those API functions will be necessary in the final versions of the protocols, while we need to assure ABI stability to some degree.

This adds a header trick to expose private functions through a new function _gnutls_ephemeral_get, which returns an internal function symbol.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated / NEWS entry present (for non-trivial changes)
  • CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTION.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited Mar 01, 2021 by Daiki Ueno
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: tmp-ephemeral-api