GitLab's annual major release is around the corner. Along with a lot of new and exciting features, there will be a few breaking changes. Learn more here.

Commit f5a1b253 authored by Daniel Kahn Gillmor's avatar Daniel Kahn Gillmor
Browse files

certtool: Align warning about --provable with actual code



If I try to generate an ed25519 key, it is *not* an ECDSA key.  But I
see this warning:

    0 dkg@host:~$ certtool --generate-privkey --provable --key-type ed25519
    Generating a 256 bit EdDSA (Ed25519) private key ...
    The --provable parameter cannot be used with ECDSA keys.
    1 dkg@host:~$

Looking at the code and documentation, it's clear that --provable only
works for RSA and DSA.  This fix aligns the warning message with the
underlying mechanism.
Signed-off-by: Daniel Kahn Gillmor's avatarDaniel Kahn Gillmor <dkg@fifthhorseman.net>
parent 0d112fb8
......@@ -197,7 +197,7 @@ generate_private_key_int(common_info_st * cinfo)
if (provable && (!GNUTLS_PK_IS_RSA(key_type) && key_type != GNUTLS_PK_DSA)) {
fprintf(stderr,
"The --provable parameter cannot be used with ECDSA keys.\n");
"The --provable parameter can only be used with RSA and DSA keys.\n");
app_exit(1);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment