Implementation of GNU Radio blocks for different data types
Quoting @odrisci from https://github.com/gnss-sdr/gnss-sdr/issues/69:
I've been thinking a bit about the implementation of the
pcps_acquistion_sc
- it really pains me to have two classes with almost identical implementation, it makes for a real code maintenance headache. One possible solution would be to make the current implementation a genericpcps_acquisition
block that would take anitem_type
parameter as input. From what I can see the currentpcps_acquisition_sc
simply converts the input fromlv_16sc_t
togr_complex
using a volk kernel and then implements precisely the same functionality aspcps_acquisition_cc
. I'm hacking together a solution along these lines for my personal use, do you think this would be a good idea? Or is the separation of blocks into specific implementations for specific data types a key design decision withingnss-sdr
?