`launchctl setenv` no longer sets env variable in 3.2.8

Thanks for filing an issue! Please answer the questions below so I can help you.

• iTerm2 version: 3.2.8

• OS version: MacOS 10.13.6

• Attach [com.googlecode.iterm2.plist] here (drag-drop from finder into this window) (/uploads/2a25922f18d7f58b83470ee21a609f91/com.googlecode.iterm2.plist)

• Attach a debug log, if possible. Instructions at https://iterm2.com/debuglog

• Are you reporting a performance issue, excessive CPU usage, or a hang? Please attach a sample. Instructions at https://gitlab.com/gnachman/iterm2/wikis/HowToSample

• Are you reporting a crash? Please attach the crash log. Instructions at https://gitlab.com/gnachman/iterm2/wikis/crash-logs

• Are you reporting excessive memory usage? Please attach a heap analysis: https://gitlab.com/gnachman/iterm2/wikis/heapshot

Detailed steps to reproduce the problem:

1. launchctl setenv hello world
2. Quit iTerm2 completely
3. Start it again and type echo $hello

What happened: $hello environment variable is not set

What should have happened: hello should be set to world

This works just fine in iTerm2 3.2.7

Also, I verified that setting the variable via launchtl setenv in a different terminal app WILL reflect correctly in iTerm 3.2.8 after. So it is the setting that is broken.