GitLab

When you do ED 2 (CSI 2 J) in alternate screen when visible marks are present and the screen is empty (or marks occur below the last non-empty line), scroll the marks off the screen.

Create a general method for idempotent side effects and use it for setNeedsRedraw and intervalTreeVisibleRangeDidChange

Avoid copying the colormap on sync. Instead, mirror changes to the mutable colormap in the immutable one in side-effects like we do for the interval tree. Refactor some color-setting code to make it faster. Also fix a hang on launch when concurrency is disabled.

Sync before and after nested joined side effects so that changes to the colormap are reflected in the delegate's copy.

Make setMutingAmount and setDimOnlyText be side-effect-free when no change is made to avoid infinite recursion in setConfig:.

Move throughput estimation to mutation thread.

Don't use AsciiData asynchronously: that's a USF. Intead, make a copy before dispatching if logging is needed.

Change how updates from the mutation thread to the main thread (for the purposes of changing cadence, setting active, etc.) works. Bundle up info into VT100ScreenTokenExecutorUpdate and send updates periodically while input is being handled. The delegate interface in TokenExecutor for these is also simplified to a single call.

Add maybeHasExpectations to iTermExpect since getting the array of expectations is slow.

Add low-priority side-effects. They get quued to run but do not cause an immediate dispatch to the main queue every time. It uses a
PeriodicScheduler to ensure they are dispatched within 33 ms. This greatly improves performance.

Add PeriodicScheduler to help coalesce repeated operations. This is similar to iTermRateLimitedUpdate but is quite a bit simpler and works off the main thread.

Reduce calls to [NSDate date] during mutation since it is slow.

Add various small optimizations to VT100Grid.

Coalesce calls to intervalTreeVisibleRangeDidChange.

Make performingJoinedBlock a class property to avoid deadlock when performJoinedBlock is reentrant with two different screens, as when detaching from tmux.

Avoid mutating nil interval tree objects. I am sad that despite nullability annotations the compiler can't catch this.

Avoid checking if termType contains screen on every token because doing so is slow.

Avoid calling logging side-effects or creating strings while appending ascii data if they are not needed.

Make trigger delegate callsbacks go through TokenExecutor's scheduler when async to avoid unpausable work accruing on the mutation queue.

Fix a data race - intervals were shared between the mutable and derivative interval trees.

Improve MutableAtomicObject by adding a set method.

Prevent re-entrant side effects. I noticed you could get two alerts from alert triggers at the same time because the runloop allows events (which could kick off high-pri tasks, which could themselves have side-effects) to run while the main queue is blocked. This means side effects could potentially run long after syncing state. Keep an eye out for problems with this.

Enable concurrent VT100ScreenState use/mutation by advanced pref. Fix various data races and add assertions.

Make iTermImageInfoReading to isolate the mutation points. The class was already designed to be used concurrently, so this is just sugar.

* ARCify VT100WorkingDirectory, iTermImageInfo, iTermMark.
* Move code->iTermImageInfo map into a new class, ImageRegistery.
* Make various classes immutable (VT100RemoteHost, VT100WorkingDirectory, iTermCapturedOutputMark, iTermImageMark)
* Make LineBlock's observers an ObjC array because it's impossible to reason about object lifetimes in C++ data structures.
* Fix a leak of metadata line copied line blocks.
* Fix use after dealloc of _shell when replacing a terminated session.
* Fix leak of VT100ScreenState in sync.
* Don't register VT100ScreenMark doppelgangers.
* Fix oob write when changing cusor type while it's in the overflow column
* Fix a race that made restoring images not always work (garbage collected prematurely)

Sure PTYTextView's colormap is up to date. Fix various mis-uses of the interval tree and clean up the code, renaming it to EventuallyConsistentIntervalTree.

This reverts commit 11c06608.