12.0 Create retrospective
This is an asynchronous retrospective for the 12.0 release, following the process described at https://about.gitlab.com/handbook/engineering/management/team-retrospectives/.
This issue is private (confidential) to the Create team, plus anyone else who worked with the team during 12.0, to ensure everyone feels comfortable sharing freely. On 2019-07-19, the day of the engineering-wide 12.0 Retrospective, the issue will be opened up to the public, as long as everyone is comfortable with this. You're free to redact any comments that contain information that you'd like to stay private before that date.
Please look at back at your experiences working on this release, ask yourself
For each point you want to raise, please create a new discussion with the relevant emoji, so that others can weigh in with their perspectives, and so that we can easily discuss any follow-up action items in-line.
If there is anything you are not comfortable sharing here, please message your manager directly. Note, however, that 'Emotions are not only allowed in retrospectives, they should be encouraged', so we'd love to hear from you here if possible.
Issues we shipped
- Redefine patching workflow
- No spaces between buttons in Download dropdown when scrollbar is present
- Create's 3 most consequential JBTD
- Enable Golang-migrated features on live environments
- Expose design blobs through a new controller
- Move away from socket.io
- Mark as resolved status for comments depends solely on color
- Elasticsearch rake tasks should respect new elasticsearch limited namespaces / projects functionality
- Repository size check doesn't work properly when many branches or tags are pushed
- Errors during indexing gitlab-ee repo
- Heading in Web IDE's empty state should be updated
- Default Web IDE's merge request checkbox to true
- Display console messages, if available, in the Golang version of gitlab-shell
- Remove
approval_rules
feature flag and remove obsolete approvals implementation - Move EE differences for
views/profiles/keys/_key.html.haml
- Move EE differences for
app/views/repository_check_mailer/notify.html.haml
- Move EE differences for
app/views/projects/commits/show.html.haml
- Move EE differences for
app/views/projects/commits/_commit.html.haml
- "Show whitespace changes" Issues
- Apply/retrieve diff patches in the CI build mirror service
- Couple updating MR merge ref and determining MR mergeability
- Remove diff_tree_filtering feature flag
- [MR discussions] Slow
DiffNote#support_suggestion?
calls - Move EE differences for
app/assets/javascripts/vue_merge_request_widget/mr_widget_options.vue
- Move EE differences for
app/assets/javascripts/vue_merge_request_widget/components/states/ready_to_merge.vue
- Add commit_committer_check to the /projects/:id/push_rule API endpoint
- Implement session endpoint to proxy build services requests
- Cache markdown fields for commits in redis
- Remove the circuit breaker API
- Migrate gitlab-shell git push support to Golang
- Migrate gitlab-shell git fetch support to Golang
- API support for committing changes based on start branch in different project in same fork network
- Better error handling for Elastic
- Move EE differences for app/views/projects/merge_requests/index.html.haml
- Move EE differences for
app/views/profiles/keys/_key_details.html.haml
- New branch push is incorrectly failing size file gitlab hook
- Move EE differences for
app/views/projects/settings/repository/show.html.haml
- WebIDE doesn't work on empty repositories
- Improve repository browsing performance using Vue
- Merge when pipeline succeeds refresh failure
- elastic: number of shards seems hardcoded to 5, and replicas to 1
- More issues - this list only includes deliverables!
Issues that slipped
- After deleting all files in a directory, new files can't be uploaded to it via the Web IDE
- Cannot delete and upload file of the same name in the Web IDE
- Re-name files in Web IDE in a more natural way
- GitLab hosted Codesandbox
- zero-downtime Elasticsearch re-indexing
- Remove feature flag for named
multiple_code_owner_rules
- Add point of interest discussions to designs
- Specify that an MR must be merged after another MR
- No source when switching back to edit, after resizing markdown preview
- Live preview (server side evaluation) application in Web IDE
- [Elasticsearch] Decouple schema and search code from the rest of the codebase to allow for versioned schema
- Total deliverables closed: 41
- Total issues closed: 91
- Total MRs merged: 160