Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • D desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 58
    • Issues 58
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gitter
  • desktop
  • Issues
  • #216
Closed
Open
Created Oct 03, 2017 by Nick Sloan@nicksloan

Pop-out OAuth2 flow to trusted browser

Pop-out OAuth2 flow to trusted browser instead of putting it inside a webframe within the app which can be spied if Gitter was malicious.


An important facet of OAuth2 authorization code and implicit grants is that the user agent that serves as transport for the authorization must be independent of the client, and must be trusted by the end user. It is possible for a user agent to mislead the user about whether their credentials are being stored or transmitted to an unintended location, and a user agent could also give the OAuth2 server false input to the authorization prompt.

The Gitter Desktop app has no need to demand that level of trust from its users. Instead, the Gitter app should rely on the operating system to invoke the user's preferred web browser to serve as transport for the authorization. Anything less is a misuse of OAuth2.


ref, https://gitter.im/gitterHQ/gitter?at=59d3dccdb20c642429bb7734

Workaround

See https://gitlab.com/gitlab-org/gitter/desktop#manually-sign-inauthorize

Edited Apr 29, 2019 by Eric Eastwood
Assignee
Assign to
Time tracking