Commit c1ce9c06 authored by Denton Liu's avatar Denton Liu Committed by Junio C Hamano

completion: learn to complete `git rebase --onto=`

In 2b9bd488 ("completion: teach rebase to use __gitcomp_builtin",
2019-09-12), the completion script learned to complete rebase using
__gitcomp_builtin(). However, this resulted in `--onto=` being suggested
instead of `--onto `.

Before, when there was a space, we'd start a new word and, as a result,
fallback to __git_complete_refs() and `--onto` would be completed this
way. However, now we match the `--*` case which does not know how to
offer completions for refs.

Teach _git_rebase() to complete refs in the `--onto=` case so that we
fix this regression.
Reported-by: default avatarPaul Jolly <>
Signed-off-by: Denton Liu's avatarDenton Liu <>
Signed-off-by: default avatarJunio C Hamano <>
parent aeeb978b
......@@ -2021,6 +2021,10 @@ _git_rebase ()
__gitcomp "$__git_whitespacelist" "" "${cur##--whitespace=}"
__git_complete_refs --cur="${cur##--onto=}"
__gitcomp_builtin rebase "" \
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment