Skip to content
  • Philippe Blain's avatar
    sequencer: allow disabling conflict advice · ec030091
    Philippe Blain authored and Junio C Hamano's avatar Junio C Hamano committed
    Allow disabling the advice shown when a squencer operation results in a
    merge conflict through a new config 'advice.mergeConflict', which is
    named generically such that it can be used by other commands eventually.
    
    Remove that final '\n' in the first hunk in sequencer.c to avoid an
    otherwise empty 'hint: ' line before the line 'hint: Disable this
    message with "git config advice.mergeConflict false"' which is
    automatically added by 'advise_if_enabled'.
    
    Note that we use 'advise_if_enabled' for each message in the second hunk
    in sequencer.c, instead of using 'if (show_hints &&
    advice_enabled(...)', because the former instructs the user how to
    disable the advice, which is more user-friendly.
    
    Update the tests accordingly. Note that the body of the second test in
    t3507-cherry-pick-conflict.sh is enclosed in double quotes, so we must
    escape them in the added line. Note that t5520-pull.sh, which checks
    that we display the advice for 'git rebase' (via 'git pull --rebase...
    ec030091