Enforce usage of feature flag using dangerbot
Why?
Action item from FCL for incident 8619.
Tighten review process to ensure feature flag is not missed in critical changes. Related discussion thread: #422 (comment 1335314596)
Proposal
Have Dangerbot ensure the presence of either 2 new labels: feature flag::added
or feature flag::skipped
. If a developer chooses to do feature flag::skipped
, a comment on the MR about the decision making behind skipping the flag would be needed.
Definition of Done
- An MR is opened with proposed Dangerbot rule and ready for review by Engineering Productivity
Edited by Albert