## Bug Report Once the project of a `gitlab_project_integration_datadog`, `gitlab_project_integration_jenkins` or `gitlab_project_integration_harbor` has been deleted outside of Terraform, every `terraform plan` fails with `Unable to read ... integration: 404 Not Found` until the resources are removed by hand with `terraform state rm`. GitLab answers `GET /projects/:id/integrations/:slug` with `404 Project Not Found` once the project no longer exists. The three resources turn any error from that GET into a diagnostic ([Datadog L158-162](https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/6cbee813425e5be102ea6f402c47a49a2ccbd605/internal/provider/resource_gitlab_project_integration_datadog.go#L158-162), [Jenkins L151-155](https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/6cbee813425e5be102ea6f402c47a49a2ccbd605/internal/provider/resource_gitlab_project_integration_jenkins.go#L151-155), [Harbor L146-150](https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/6cbee813425e5be102ea6f402c47a49a2ccbd605/internal/provider/resource_gitlab_project_integration_harbor.go#L146-150)). Their `Delete` does the same with the 404 of the DELETE, so `terraform destroy -refresh=false` fails too ([Datadog L195-202](https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/6cbee813425e5be102ea6f402c47a49a2ccbd605/internal/provider/resource_gitlab_project_integration_datadog.go#L195-202), [Jenkins L175-182](https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/6cbee813425e5be102ea6f402c47a49a2ccbd605/internal/provider/resource_gitlab_project_integration_jenkins.go#L175-182), [Harbor L184-191](https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/6cbee813425e5be102ea6f402c47a49a2ccbd605/internal/provider/resource_gitlab_project_integration_harbor.go#L184-191)). The other 18 integration resources built on the plugin framework treat a 404 in `Read` as the integration being gone and remove it from the state, for example `gitlab_project_integration_telegram` ([L188-196](https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/6cbee813425e5be102ea6f402c47a49a2ccbd605/internal/provider/resource_gitlab_project_integration_telegram.go#L188-196)) and `gitlab_group_integration_harbor` ([L154-162](https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/blob/6cbee813425e5be102ea6f402c47a49a2ccbd605/internal/provider/resource_gitlab_group_integration_harbor.go#L154-162)), and they ignore a 404 in `Delete`. These three are the only ones on the plugin framework that don't; `gitlab_integration_slack`, still on the SDK, handles the 404 in `Read` but not in `Delete`. Disabling the integration doesn't trigger this: GitLab keeps a disabled integration and answers the GET with `200` and `"active": false` ([`integratable_operations.rb` L132-159](https://gitlab.com/gitlab-org/gitlab/-/blob/26212baacadb5beea6664f7ef025d753dccfb0d6/lib/api/integrations/integratable_operations.rb#L132-159)). The 404 comes once the project is gone, or for an integration that was never saved, which GitLab answers with `404 Integration Not Found` ([L177-183](https://gitlab.com/gitlab-org/gitlab/-/blob/26212baacadb5beea6664f7ef025d753dccfb0d6/lib/api/integrations/integratable_operations.rb#L177-183)). ### Current behaviour `terraform plan` fails on each of the three resources with `Unable to read Datadog integration: 404 Not Found`, `Unable to read gitlab jenkins integration: 404 Not Found` and `Unable to read gitlab harbor integration: 404 Not Found`. `terraform destroy -refresh=false` fails with `Unable to delete ... integration: 404 Not Found`. ### Expected behaviour The refresh removes the integration from the state, so the plan proposes to create it again, as it does for `gitlab_project` itself and for the other integrations. A destroy treats a 404 as nothing left to delete. ## Relevant Terraform Configuration ```hcl terraform { required_providers { gitlab = { source = "gitlabhq/gitlab" version = "19.4.1" } } } provider "gitlab" { # base_url and token come from GITLAB_BASE_URL and GITLAB_TOKEN, for example # GITLAB_BASE_URL=https://gitlab.example.com/api/v4/ } resource "gitlab_project" "example" { name = "integrations-404-repro" visibility_level = "private" } resource "gitlab_project_integration_datadog" "example" { project = gitlab_project.example.id api_key = "aaaabbbbccccddddaaaabbbbccccdddd" } resource "gitlab_project_integration_jenkins" "example" { project = gitlab_project.example.id jenkins_url = "https://jenkins.example.com" project_name = "example" } resource "gitlab_project_integration_harbor" "example" { project = gitlab_project.example.id url = "https://harbor.example.com" project_name = "example" username = "example" password = "example-password" } output "project_id" { value = gitlab_project.example.id } ``` ## Relevant Terraform Command ```sh export GITLAB_BASE_URL=https://gitlab.example.com/api/v4/ export GITLAB_TOKEN=glpat-... terraform init terraform apply PROJECT_ID=$(terraform output -raw project_id) # Delete the project outside of Terraform. DELETE only marks it for deletion # and renames it, so remove it for good with the path GitLab now reports. curl --request DELETE --header "PRIVATE-TOKEN: $GITLAB_TOKEN" "${GITLAB_BASE_URL}projects/$PROJECT_ID" FULL_PATH=$(curl --silent --header "PRIVATE-TOKEN: $GITLAB_TOKEN" "${GITLAB_BASE_URL}projects/$PROJECT_ID" | jq -r .path_with_namespace) curl --request DELETE --header "PRIVATE-TOKEN: $GITLAB_TOKEN" --get "${GITLAB_BASE_URL}projects/$PROJECT_ID" \ --data permanently_remove=true --data-urlencode "full_path=$FULL_PATH" # GitLab removes the project in the background; wait until it answers 404. until [ "$(curl --silent --output /dev/null --write-out '%{http_code}' --header "PRIVATE-TOKEN: $GITLAB_TOKEN" "${GITLAB_BASE_URL}projects/$PROJECT_ID")" = 404 ]; do sleep 3; done terraform plan terraform destroy -refresh=false ``` ## Relevant Log Output I don't have a debug log for this; the plain output shows the failure. Run against a local `gitlab/gitlab-ce:19.4.1-ce.0` with provider `v19.4.1`, after the project had been removed: <details> <summary>GitLab's answers for the deleted project, and <code>terraform plan</code> (the planned <code>gitlab_project</code> attributes trimmed)</summary> ```plaintext GET /projects/47/integrations/datadog -> 404 {"message":"404 Project Not Found"} GET /projects/47/integrations/jenkins -> 404 {"message":"404 Project Not Found"} GET /projects/47/integrations/harbor -> 404 {"message":"404 Project Not Found"} gitlab_project.example: Refreshing state... [id=47] gitlab_project_integration_harbor.example: Refreshing state... [id=47] gitlab_project_integration_datadog.example: Refreshing state... [id=47] gitlab_project_integration_jenkins.example: Refreshing state... [id=47] Terraform planned the following actions, but then encountered a problem: # gitlab_project.example will be created + resource "gitlab_project" "example" { ... } Plan: 1 to add, 0 to change, 0 to destroy. Error: GitLab API error occurred with gitlab_project_integration_datadog.example, on main.tf line 20, in resource "gitlab_project_integration_datadog" "example": 20: resource "gitlab_project_integration_datadog" "example" { Unable to read Datadog integration: 404 Not Found Error: GitLab API error occurred with gitlab_project_integration_jenkins.example, on main.tf line 25, in resource "gitlab_project_integration_jenkins" "example": 25: resource "gitlab_project_integration_jenkins" "example" { Unable to read gitlab jenkins integration: 404 Not Found Error: GitLab API error occurred with gitlab_project_integration_harbor.example, on main.tf line 31, in resource "gitlab_project_integration_harbor" "example": 31: resource "gitlab_project_integration_harbor" "example" { Unable to read gitlab harbor integration: 404 Not Found ``` </details> <details> <summary><code>terraform destroy -refresh=false</code> on the same state</summary> ```plaintext gitlab_project_integration_datadog.example: Destroying... [id=47] gitlab_project_integration_jenkins.example: Destroying... [id=47] gitlab_project_integration_harbor.example: Destroying... [id=47] Error: GitLab API error occurred Unable to delete Datadog integration: 404 Not Found Error: GitLab API error occurred Unable to delete Harbor integration: 404 Not Found Error: GitLab API Error occurred Unable to delete Jenkins integration: 404 Not Found ``` </details> ## Additional Details - GitLab Terraform Provider Version: `v19.4.1` (the three files are the same on `main` at `6cbee813`) - GitLab Instance Version: `19.4.1` (CE) - Terraform Version: `v1.13.5` - License Tier: `Free` ## Possible fix In each `Read`, handle the 404 the way the other integrations do, and ignore it in `Delete`: ```go datadog, _, err := r.client.Services.GetDataDogService(projectID, gitlab.WithContext(ctx)) if err != nil { if api.Is404(err) { tflog.Debug(ctx, "Datadog integration doesn't exist, removing from state", map[string]any{ "project": projectID, }) resp.State.RemoveResource(ctx) return } resp.Diagnostics.AddError("GitLab API error occurred", fmt.Sprintf("Unable to read Datadog integration: %s", err.Error())) return } ``` An acceptance test per resource can show it the way `TestAccGitlabProjectVariable_deletedOutsideTerraform` does: create the integration, delete its project in `PreConfig`, and expect a refresh plan that creates the integration again. A project has to be deleted permanently and GitLab removes it in the background, so the test needs a small helper in `testutil` that waits until the project answers 404. With that change, the same configuration plans to create all four resources again, and `terraform destroy -refresh=false` completes. I'd like to work on this.