Error handling in group board resources
Whilst reviewing cases where errors are reported but the code erroneously carries on for !2388 (merged), there were a couple of special cases I wanted a second opinion on:
- https://gitlab.com/gitlab-community/terraform-provider-gitlab/-/blob/main/internal/provider/resource_gitlab_group_issue_board.go#L278
- https://gitlab.com/gitlab-community/terraform-provider-gitlab/-/blob/main/internal/provider/resource_gitlab_group_epic_board.go#L529
In both cases, there is a loop where each iteration might result in an error. My question is, should they fail on the first error reported in the loop, or fail after the loop if any of the iterations have reported an error?