Use restricted step context when evaluating expressions

What does this MR do?

This MR passes a view of the StepContext to expression.Expand and expression.ExpandString, guaranteeing that users cannot access internal members of the proto.StepResult from previously executed steps.

Checking for sensitivity during evaluation has been removed to make this task easier. This will be reinstated in Handling sensitive values (gitlab-org#14416).

Reference

Restrict access to internal variables in expres... (#100 - closed)

added Category:Runner Core devopsverify grouprunner runnercore sectionci typefeature labels

assigned to @cam_swords

changed title from Cam pass view to interpolate to Use restricted step context when evaluating expressions

changed the description

changed milestone to %17.5

requested review from @avonbertoldi

@cam_swords LGTM. Just one minor suggestion.

requested review from @avonbertoldi

added 1 commit

• bf39af52 - Rename outputs to stepresultsview for clarity

Compare with previous version

added 6 commits

• bf39af52...86ad19ba - 2 commits from branch main
• 84d947dd - Step runner passes a view when interpolating expressions
• c783e88e - Remove check for sensitivity when interpolating expressions
• 51d3a428 - Expressions can only access previous step outputs
• 5d730ce6 - Rename outputs to stepresultsview for clarity

Compare with previous version

approved this merge request

resolved all threads

mentioned in commit f56c856c

merged