Project settings changes for MRs
Status quo
While working on !260 (merged) I noticed that we don't enforce any kind of MR approvals on this repository so, in practice, MR maintainers could merge their own MRs without approval.
| Before setting change | After setting change |
|---|---|
 |
 |
I don't think this is a problem per se but it'd be nice to have the same workflow as we do have right now for https://gitlab.com/gitlab-org/gitlab where approval is required.
Solution
Instead of creating an issue asking for changes I went ahead and changed the following project settings demonstrating bias for action.
Screenshots
All changes were inspired by https://gitlab.com/gitlab-org/gitlab/edit.
| Before | After | |
|---|---|---|
| General Settings > Merge Requests > Merge options |  |
 |
| General Settings > Merge Requests > Merge checks |  |
 |
| General Settings > Merge Requests > Merge request approvals |  |
 |
Ideas for future?
This issue tracks the changes but also encourages further discussions about upcoming setting changes for this repo in this or separate issues