Skip to content

RFC: suggest how emojis assets copying should be handled

!39 (merged) - this MR adds node script that copies assets (json files and fallback png images) required for rendering emojis from GitLab project. In GitLab project those assets are generated by ruby gem gemojione. But in this project we do not have Ruby&its 💎. But want to mimic the same behavior for emojis. So assets generated by gem are synced to the Status Page project by this script

!62 (merged) - this MR adds emojis rendering logic and consumes assets generated by previous script

The question is where is a good place to run yarn emojis script to generate assets

Currently there are 2 approaches, but I'm open to other suggestions

Approach 1

Add CI job that would compare main json file (the list of supported emojis) in Status Page repo with the one in GitLab and if they are different fail the job that will ask user to run yarn emojis locally and commit changes. The process will be similar to updating localization files in GitLab project

Pros:

  • Faster as files won't be downloaded during each CI build
  • Less error prone due to network issues

Cons:

  • Requires manual user action (running script and committing copied files) - this won't happen often though

Approach 2

Add emojis generation to the CI build step

Pros

  • No manual user interaction

Cons

  • Longer builds due to copying assets each time