Fix Error Budget Attribution for Group Security Settings API
Problem to solve
There have been two recent error budget degradations caused by the SetGroupSecretPushProtectionWorker, which was introduced as a part of Enable SPP for all projects in a group via a ne... (gitlab-org&15840 - closed).
Degradations for reference (Slack - internal only - 90 days):
The error budget attribution was initially set to groupsecret detection because feature categories for groupsecurity platform management were not yet established/merged in categories.yml, which is necessary for attributing a new worker or API to an error budget.
Now that they have been established via Add categories for new Security Platform Manage... (gitlab-com/www-gitlab-com!137494 - merged), the APIs and the worker associated with this feature can be attributed to the appropriate feature category.
Impact
This is causing groupsecret detection's error budget to be inaccurately reported, making it harder to understand how the core components for SD are performing. This attribution is wrong and needs to be fixed so that the SD group knows when it has a scalability and availability issue in the Secret Detection features rather than its configuration. Additionally fixing this will become increasingly important as the group transitions the Secret Detection service to Active Mode, which will have an immediate impact on the error budget if there are any disruptions.
Proposal
- Update the error budget attributions for all APIs and workers associated with this feature to map to the correct feature category under groupsecurity platform management
- Confirm that the error budget reporting is accurately represented for both groups