Full MVC of gitlab-zoekt-indexer

cmd/gitlab-zoekt-indexer/main_test.go

@@ -113,8 +113,8 @@ func TestHandleStatus(t *testing.T) {
 		Success: true,
 	}
 
-	if !cmp.Equal(expectedResponse, parsedResponse) {
-		t.Fatalf("expected response %v doesn't match %v", expectedResponse, parsedResponse)
+	if diff := cmp.Diff(expectedResponse, parsedResponse); diff != "" {
+		t.Error(diff)
 	}
 }
 
@@ -151,7 +151,9 @@ func TestHandleTruncate(t *testing.T) {
 	}
 
 	server.createIndexDir()
-	defer os.RemoveAll(dir)
+	t.Cleanup(func() {
+		os.RemoveAll(dir)
+	})
 
 	testFilePath := filepath.Join(dir, "test_file.txt")
 	data := []byte("hello world")
@@ -185,7 +187,9 @@ func TestHandleIndex(t *testing.T) {
 		},
 	}
 	server.createIndexDir()
-	defer os.RemoveAll(dir)
+	t.Cleanup(func() {
+		os.RemoveAll(dir)
+	})
 
 	server.initMetrics()
 
@@ -209,7 +213,9 @@ func TestHandleIndexWhenErr(t *testing.T) {
 		},
 	}
 	server.createIndexDir()
-	defer os.RemoveAll(dir)
+	t.Cleanup(func() {
+		os.RemoveAll(dir)
+	})
 
 	server.initMetrics()
 	router := server.router()
@@ -232,7 +238,9 @@ func TestHandleIndexWhenTimeoutErr(t *testing.T) {
 		},
 	}
 	server.createIndexDir()
-	defer os.RemoveAll(dir)
+	t.Cleanup(func() {
+		os.RemoveAll(dir)
+	})
 
 	server.initMetrics()
 	router := server.router()