Image assets no longer being published with gem
When we started using the gitlab.com/gitlab-org/components/gem-release/gem-release component, the gem started being built with gem build. Unfortunately this bypassed our build rake task which also built the image assets. So those were not being included in the gem.
Now we have overridden the script piece of the build-regular-gem job to run our rake task. We've also added a gem smoke test to ensure that an emoji can be found and its image file is available.
This can be tested in this MR by setting dry_run to true in the .gitlab-ci.yml file and prepending RELEASE to the MR title.
Closes #31 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @digitalmoksha
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer No reviewer available @brodock(UTC+2, 7 hours ahead of
@digitalmoksha)If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by ****added 1 commit
- 8f135d8a - Ensure that image assets are shipped with gem
@brodock mind reviewing this MR? It fixes the problem where the assets were not being shipped in the gem.
Once merged, I think we should publish a
0.10.0version so that the assets are up there for the current set of emojis we use, before we upgrade the emoji set.-
@brodock The gem is built during the deploy stage, when the gem is going to be published. We then are able to run a smoke test before publishing to ensure it's built correctly. I don't think it's necessary to build the gem for each commit. And since we're not shipping anything that needs to be compiled natively, I'm not sure it's that helpful to build the gem for every version of ruby.
Many of these changes were pulled from the changes made to prometheus-client-map and gitlab-glfm-markdown gems that integrated the https://gitlab.com/gitlab-org/components/gem-release component
Currently the component builds with Ruby 3.1
requested review from @brodock
mentioned in merge request !64 (closed)
-
@brodock based on your comment
The reason we had the gem build before in each MR is to find any build failure that would happen during the gem build/install step. This can be, for example, when a new dependency changes or when the gem metadata is updated
I've added back building the gem on each push, and added a smoke test for assets for that build.
You can look at https://gitlab.com/gitlab-org/ruby/gems/tanuki_emoji/-/pipelines/1475831064 to see the entire release pipeline dry run.
This should be ready for another review.
@digitalmoksha Thanks, LGTM!
mentioned in commit f39cbd93
mentioned in merge request gitlab-org/gitlab!170017 (closed)
mentioned in merge request gitlab-org/gitlab!170967 (closed)
