Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P prometheus-client-mmap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • ruby
  • gems
  • prometheus-client-mmap
  • Merge requests
  • !59
Project 'gitlab-org/prometheus-client-mmap' was moved to 'gitlab-org/ruby/gems/prometheus-client-mmap'. Please update any links and bookmarks that may still have the old path.

Drop deprecated `taint` mechanism; add Ruby 3 build to CI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Aleksei Lipniagov requested to merge alipniagov-add-ruby-3-build into master Aug 25, 2021
  • Overview 4
  • Commits 2
  • Pipelines 3
  • Changes 4

Taint checking has been deprecated starting Ruby 2.7: https://bugs.ruby-lang.org/issues/16131. It is well described, for example, here: https://blog.saeloun.com/2020/02/18/ruby-2-7-access-and-setting-of-safe-warned-will-become-global-variable.html

As a result, we receive warnings in our CI when running Ruby 3 builds, e.g.: https://gitlab.com/gitlab-org/gitlab/-/jobs/1524901589#L409

Related to gitlab#339001

Edited Aug 25, 2021 by Aleksei Lipniagov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: alipniagov-add-ruby-3-build